Re: master a154f0aa73b: shell-command-mode: New major mode for async-shell-command

[Robert Pluim]

>>>>> On Fri, 13 Sep 2024 01:25:01 +0300, Dmitry Gutov <dmitry@gutov.dev> said:

    Dmitry> On 12/09/2024 14:58, Robert Pluim wrote:
    >> Itʼs probably too late to change for emacs-30, but any particular
    >> reason this is a `defvar' instead of a `defcustom'?

    Dmitry> A user option implies validity of different options, but as you can
    Dmitry> see the new major mode is there to fix a bug (a long-standing one, I
    Dmitry> guess), and the defvar is for any users who feel their workflows 
break
    Dmitry> because of that.

Well, the `defvar' also implies that some people might prefer the old
behaviour ☺️. But those people almost certainly know how to wield `setq'.

    Dmitry> Not sure who would be the target audience, though.

If you code it they will come.

Robert
--