emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: last_marked array is now ifdef'ed away


From: Eli Zaretskii
Subject: Re: last_marked array is now ifdef'ed away
Date: Sun, 15 Sep 2024 17:21:21 +0300

> From: Mattias Engdegård <mattias.engdegard@gmail.com>
> Date: Sun, 15 Sep 2024 15:58:03 +0200
> Cc: emacs-devel@gnu.org
> 
> 15 sep. 2024 kl. 07.51 skrev Eli Zaretskii <eliz@gnu.org>:
> 
> > I'd need to see actual evidence for a shorter array, based on actual
> > GC run of some data structure.
> 
> And I'd need to see actual evidence for a longer array, based on actual 
> debugging cases.

There's no need for any evidence to keep the code which we always had.
Evidence is needed when changes are suggested that modify stuff in
significant ways.

> But perhaps there is a way for both of us to be just slightly disappointed: 
> what about gating the check with a flag? That way, the trace buffer is always 
> compiled-in. It needs to be enabled by the user but that is straightforward 
> and can be done on the command line, in Lisp, or in a debugger.

That won't help because GC crashes are seldom if ever reproducible.
So if the trace is off, the information is gone and cannot be
recovered in practice.

I'm not just being stubborn, there really is no way around this.
Leaving this disabled, no matter in what way, basically means we
delete the feature.  Because it can never be enabled in time for the
problem to strike.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]