[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser
From: |
Stefan Kangas |
Subject: |
Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324) |
Date: |
Sat, 21 Sep 2024 17:59:08 -0700 |
Po Lu <luangruo@yahoo.com> writes:
> Yuan Fu <casouri@gmail.com> writes:
>
>> branch: emacs-30
>> commit f0daa2f2153a9d250d32ac1261a6fffb30860e31
>> Author: Yuan Fu <casouri@gmail.com>
>> Commit: Yuan Fu <casouri@gmail.com>
>>
>> Conservative heuristic for tree-sitter parser ranges (bug#73324)
>>
>> * src/treesit.c (treesit_sync_visible_region): If the parser's original
>> ranges don't overlap with visible region, give it a zero range, rather
>> than don't set any range.
>> * test/src/treesit-tests.el (treesit-range-fixup-after-edit): Test new
>> behavior.
>
> Please fill ChangeLog entries in commit messages to a width of 64
> columns, not 71 or 72, as here.
I don't want to get into another argument about this, but I don't see
any problem with the above formatting, FWIW.
In any case, I really don't think it is a good use of our time to police
the recently introduced default of 64 columns here. We never did that
before, when the default in `vc-git-log-edit-mode' was 70 characters,
and there is no reason to start doing it now.
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Po Lu, 2024/09/18
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324),
Stefan Kangas <=
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Eli Zaretskii, 2024/09/22
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Po Lu, 2024/09/22
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Yuan Fu, 2024/09/22
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Kévin Le Gouguec, 2024/09/22
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Robert Pluim, 2024/09/23
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Eli Zaretskii, 2024/09/23
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Kévin Le Gouguec, 2024/09/23
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Eli Zaretskii, 2024/09/23
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Kévin Le Gouguec, 2024/09/24
- Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324), Yuan Fu, 2024/09/26