emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser


From: Yuan Fu
Subject: Re: emacs-30 f0daa2f2153: Conservative heuristic for tree-sitter parser ranges (bug#73324)
Date: Sat, 21 Sep 2024 23:44:38 -0700


> On Sep 21, 2024, at 10:43 PM, Po Lu <luangruo@yahoo.com> wrote:
> 
> Stefan Kangas <stefankangas@gmail.com> writes:
> 
>>> Please fill ChangeLog entries in commit messages to a width of 64
>>> columns, not 71 or 72, as here.
>> 
>> I don't want to get into another argument about this, but I don't see
>> any problem with the above formatting, FWIW.
>> 
>> In any case, I really don't think it is a good use of our time to police
> 
> It is a good (and a exceedingly slight) use of my time.
> 
>> the recently introduced default of 64 columns here.  We never did that
>> before, when the default in `vc-git-log-edit-mode' was 70 characters,
>> and there is no reason to start doing it now.
> 
> That point is moot when most of us were self-consciously observing this
> standard before it was formalized in .dir-locals.el.

I took a look and it’s set for log-edit-mode only. It would be nice if magit 
can pick it up. I’m sure a lot of people (me included) use magit for developing 
Emacs. The only problem is magit’s commit message editing buffer doesn’t have a 
special major mode. It does git-commit-mode which is a minor mode, and runs 
git-commit-setup-hook. But I’m not sure how to edit dir-locals to set 
fill-column using a hook or minor mode.

Yuan


reply via email to

[Prev in Thread] Current Thread [Next in Thread]