emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)


From: Tassilo Horn
Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)
Date: Mon, 23 Sep 2024 14:05:30 +0200
User-agent: mu4e 1.12.6; emacs 31.0.50

Eli Zaretskii <eliz@gnu.org> writes:

>> Eli, what do you think?
>
> Sorry, I don't understand what you are asking me about.  Please
> elaborate
>
> It sounds like PDF documents with colors have inherent problems with
> doc-view-mupdf-use-svg and/or themes, so maybe we should warn about
> this in NEWS and in the doc string, and suggest that people either
> customize the doc-view-svg-face, or disable doc-view-mupdf-use-svg.

Yes, exactly.  There can be foreground-similar-to-background color
issues when mupdf + doc-view-mupdf-use-svg is used for certain, not
uncommon documents.

We can either document that issue in NEWS and docstrings, or we can
simply set "black on white" as default value of doc-view-svg-face which
would eliminate those problems (and match what we had in emacs 29 before
the face was introduced by Manuel Giraud) but would stop trying to apply
our emacs theme to the document, too.

I'd rather be conservative, use "black on white" as doc-view-svg-face
default value and document in NEWS and doc-view-svg-face's docstring
that one can style documents according to the emacs theme by inheriting
from the default face and not explicitly setting foreground and
background colors.

Bye,
  Tassilo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]