emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)


From: Tassilo Horn
Subject: Re: No NEWS entry for doc-view-mupdf-use-svg (Emacs 30.0.91 feedback)
Date: Mon, 23 Sep 2024 20:35:32 +0200
User-agent: mu4e 1.12.6; emacs 31.0.50

Manuel Giraud via "Emacs development discussions." <emacs-devel@gnu.org> writes:

Hi Manuel,

>> -(defface doc-view-svg-face '((t :inherit default))
>> +(defface doc-view-svg-face '((t :inherit default
>> +                                :background "white"
>> +                                :foreground "black"))
>
> Since this face is used only for its foreground and background colors,
> I think you could leave the :inherit.

I know.  But that makes it slightly easier to turn on styling by theme.
Or, well, having both nil without inheriting has the same effect, but as
you have said, explicit is better.  I agree with that, so I kept it on
purpose.

Bye,
  Tassilo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]