Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer

[Sebastián Monía]

I just realized that I sent this only to Adam instead of the
mailing list. 

My assignment did come through, and I still think there's value
in merging the current patch (without auto-reverting).

On Thu, Oct 17, 2024, at 10:37 AM, Sebastián Monía wrote:
> Adam Porter <adam@alphapapa.net> writes:
> 
> > On 10/14/24 21:59, Sebastián Monía wrote:
> >> I was looking into it, we "just" need a good 'buffer-stale-function'.
> >> All I could think of was to store the list used to populate the vtable
> >> in a buffer-local variable, and check if the list has changed?
> >
> > AFAIK it's generally good to avoid adding more buffer-local variables,
> > as their presence has a performance penalty in general.
> 
> Noted!
> 
> > Updating a buffer list buffer automatically could be done by hooking
> > into the machinery that renders a single EWW buffer and having it
> > update a buffer list buffer if one exists.  But I guess that wouldn't
> > work exactly like `auto-revert-mode` and `buffer-stale-function`.
> 
> That same machinery could trigger auto-revert by marking the "buffer list"
> buffer stale.
> 
> > I don't mean to say what you should do; just throwing out some ideas.  :)
> 
> And it is much appreciated! :)
> 
> I don't think we should hold on merging this for auto-reverting though.
> The patch is big enough as it is.
> IMHO.
> 
> 
> PS: still can't merge as my assignment didn't come through.
> 
> -- 
> Sebastián Monía
> https://site.sebasmonia.com/