emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master b573aaab76b 2/2: ; Make utility functions for getting the Esh


From: Jim Porter
Subject: Re: master b573aaab76b 2/2: ; Make utility functions for getting the Eshell non-special regexps
Date: Mon, 21 Oct 2024 14:26:21 -0700

On 10/21/2024 1:00 AM, Andrea Corallo wrote:
If I'm not wrong this commit once merged into master is causing the
following warnings:

eshell/em-script.el:75:9: Warning: Unused lexical variable
‘eshell-outside-quote-regexp’

eshell/em-script.el:74:9: Warning: Unused lexical variable
‘eshell-inside-quote-regexp’

Would you ming having a look?

Thanks for letting me know. It turns out there was an actual bug here that my previous change helped reveal: the previous code was trying to work around the fact that the Eshell startup scripts were running before the Eshell session was fully-initialized, which is iffy at best.

I've now changed this so that there's a new 'eshell-after-initialize-hook' that em-script.el can use. That's more correct and lets us avoid the let-binding that caused this warning.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]