Re: Comint-like history search for Eshell?

[James Thomas]

Pengji Zhang wrote:

> Hallo!
>
> I hacked a small patch (attached) implementing a comint-like interface
> for history search in Eshell, and I would like to know what people think
> about it. You may type 'M-r' in Eshell to try the interface.
>
> I myself always miss the 'M-r' in 'M-x shell' whenever I use 'M-r' in
> Eshell. I tried 'eshell-isearch-{forward,backward}', but IMO they are a
> bit rough -- they are implemented by inserting the whole history file
> into the buffer and overriding Isearch keys.
>
> This patch is mostly copied from comint.el (or simple.el), and it is
> basically a proof of concept. Before I submit it to the bug tracker, I
> would like to gather some input regarding the change. Thanks in advance!

Thanks! I don't intend to read the code, but I've applied it and started
testing. Haven't run into any issues for the past 5 minutes. :-)

Regards,
James