Re: Comint-like history search for Eshell?

[Jim Porter]

On 11/3/2024 5:23 AM, Pengji Zhang wrote:
> I hacked a small patch (attached) implementing a comint-like interface
> for history search in Eshell, and I would like to know what people think
> about it. You may type 'M-r' in Eshell to try the interface.

Thanks for the patch!

Just some general thoughts before I do a more-thorough review: as I see 
it, there are two competing ideas for how a user might look up a prior 
command: using Isearch (as in this patch) or using completion. Both have 
some similarities, but the latter has the advantage of letting you use 
the various completion frameworks for filtering/displaying the results.

I don't know if one or the other is "better" overall; I imagine which 
one a user would prefer just depends on individual preference. (That 
said, I think I'd probably use a completion-based command history if I 
had the option.)

For this patch in particular, I think it would probably make sense to at 
least see about leaving the door open for a completion-based history 
lookup in Eshell. I haven't thought very hard about what that would look 
like yet though...