Re: [PATCH] image-dired-show-all-from-dir: reuse dired's default directory

[Stefan Kangas]

Sacha Chua <sacha@sachachua.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
> Hello, Stefan!
>
>> Thanks for the patch, and interesting use case.
>> I can't find the variable `dired-default-directory`, but I do see that a
>> function of that name was removed in Emacs 27.  Where did you find that
>> variable, and which version of Emacs are you running?  Could it be that
>> this variable is from a third-party package?
>
> Oh! That's a coincidence, I hadn't known that was used before. We can
> call it temp-default-directory or something else if you prefer. I called it
> dired-default-directory because I just needed to temporarily store the
> default-directory from the dired buffer so that we could copy it to the
> image-dired-thumbnail-buffer, which is why it's a let-bound variable.

Ah, my bad.  I got confused and thought it was supposed to be a special
variable.

I think your patch looks basically good, but let me take a proper look
before installing it.