emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] feat: add markdown-ts-mode


From: Juri Linkov
Subject: Re: [PATCH] feat: add markdown-ts-mode
Date: Mon, 14 Apr 2025 09:36:05 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/31.0.50 (x86_64-pc-linux-gnu)

>>> Just tried your patch Yuan.
>>> 
>>> I've gotta admit it's a breeze to see 'stock Emacs' showing LSP
>>> documentation (eglot feeding eldoc)
>>> properly colored (I hacked eldoc to load markdown-ts-mode, attached 
>>> screenshot).
>> 
>> Awesome :)
>> 
>>>> +(defvar markdown-ts-code-block-source-mode-map
>>>> +  '((javascript . js-ts-mode))
>>>> +  "An alist of supported code block languages and their major mode.")
>>> 
>>> Should we start adding modes here or is it something we're gonna
>>> provide a default and let it up to the user?
>> 
>> If this works well, we’ll definitely add other builtin tree-sitter
>> modes. We probably should also add something similar to what org mode
>> and markdown-mode have, for language that don’t have a tree-sitter
>> mode. But I’m not volunteering for that :)
>
> Should we merge the aforementioned patch?

It would be nice to merge it, so we could continue
developing the feature that adds more modes automatically.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]