[Emacs-diffs] emacs/lisp ChangeLog wid-edit.el

[Glenn Morris]

CVSROOT:        /sources/emacs
Module name:    emacs
Changes by:     Glenn Morris <gm>       09/05/02 23:44:03

Modified files:
        lisp           : ChangeLog wid-edit.el 

Log message:
        (widget-specify-field, widget-field-value-get, character):
        Revert 2009-03-24 change, since it causes a more serious problem than
        the one it solves.  (Closes Bug#3136, reopens Bug#2689.)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/ChangeLog?cvsroot=emacs&r1=1.15623&r2=1.15624
http://cvs.savannah.gnu.org/viewcvs/emacs/lisp/wid-edit.el?cvsroot=emacs&r1=1.199&r2=1.200

Patches:
Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.15623
retrieving revision 1.15624
diff -u -b -r1.15623 -r1.15624
--- ChangeLog   2 May 2009 08:33:25 -0000       1.15623
+++ ChangeLog   2 May 2009 23:44:00 -0000       1.15624
@@ -1,3 +1,9 @@
+2009-05-02  Glenn Morris  <address@hidden>
+
+       * wid-edit.el (widget-specify-field, widget-field-value-get, character):
+       Revert 2009-03-24 change, since it causes a more serious problem than
+       the one it solves.  (Closes Bug#3136, reopens Bug#2689.)
+
 2009-05-02  Martin Rudalics  <address@hidden>
 
        * frame.el (pop-up-frame-function): Remove choice nil since it
@@ -253,7 +259,7 @@
 
 2009-04-09  Richard M Stallman  <address@hidden>
 
-       * mail/rmailkwd.el (rmail-set-label): Warn if multipe labels spec'd.
+       * mail/rmailkwd.el (rmail-set-label): Warn if multiple labels spec'd.
        (rmail-kill-label, rmail-add-label): Doc fixes.
 
        * mail/rmailout.el (rmail-output): If file is visited,

Index: wid-edit.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/wid-edit.el,v
retrieving revision 1.199
retrieving revision 1.200
diff -u -b -r1.199 -r1.200
--- wid-edit.el 24 Mar 2009 02:30:22 -0000      1.199
+++ wid-edit.el 2 May 2009 23:44:03 -0000       1.200
@@ -342,16 +342,12 @@
         (or (not widget-field-add-space) (widget-get widget :size))))
     (if (functionp help-echo)
       (setq help-echo 'widget-mouse-help))
-    (when (and (> to (1+ from))
-              (= (char-before to) ?\n))
+    (when (= (char-before to) ?\n)
       ;; When the last character in the field is a newline, we want to
       ;; give it a `field' char-property of `boundary', which helps the
       ;; C-n/C-p act more naturally when entering/leaving the field.  We
       ;; do this by making a small secondary overlay to contain just that
       ;; one character.
-      ;; We DON'T do this if the field just consists of a newline, eg
-      ;; when specifying a character, since it breaks things (below
-      ;; does 1- to, which results in to = from).  Bug#2689.
       (let ((overlay (make-overlay (1- to) to nil t nil)))
        (overlay-put overlay 'field 'boundary)
         ;; We need the real field for tabbing.
@@ -1949,9 +1945,7 @@
          (set-buffer buffer)
          (while (and size
                      (not (zerop size))
-                     ;; Bug#2689.  Don't allow this loop to reduce a
-                     ;; character field to zero size if it contains a space.
-                     (> to (1+ from))
+                     (> to from)
                      (eq (char-after (1- to)) ?\s))
            (setq to (1- to)))
          (let ((result (buffer-substring-no-properties from to)))
@@ -3456,8 +3450,7 @@
   :value 0
   :size 1
   :format "%{%t%}: %v\n"
-  ;; `.' does not match newline, but newline is a valid character.
-  :valid-regexp "\\`\\(.\\|\n\\)\\'"
+  :valid-regexp "\\`.\\'"
   :error "This field should contain a single character"
   :value-to-internal (lambda (widget value)
                       (if (stringp value)