emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r100478: Add some comments related to


From: Glenn Morris
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r100478: Add some comments related to how epaths.h gets built.
Date: Sat, 29 May 2010 11:54:16 -0700
User-agent: Bazaar (2.0.3)

------------------------------------------------------------
revno: 100478
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Sat 2010-05-29 11:54:16 -0700
message:
  Add some comments related to how epaths.h gets built.
modified:
  Makefile.in
  configure.in
=== modified file 'Makefile.in'
--- a/Makefile.in       2010-05-17 21:02:06 +0000
+++ b/Makefile.in       2010-05-29 18:54:16 +0000
@@ -279,6 +279,9 @@
 removenullpaths=sed -e 's/^://g' -e 's/:$$//g' -e 's/::/:/g'
 
 # Generate epaths.h from epaths.in.  This target is invoked by `configure'.
+# See comments in configure.in for why it is done this way, as opposed
+# to just letting configure generate epaths.h from epaths.in in a
+# similar way to how Makefile is made from Makefile.in.
 epaths-force: FRC
        @(lisppath=`echo ${lisppath} | ${removenullpaths}` ;            \
          buildlisppath=`echo ${buildlisppath} | ${removenullpaths}` ;  \

=== modified file 'configure.in'
--- a/configure.in      2010-05-28 04:25:06 +0000
+++ b/configure.in      2010-05-29 18:54:16 +0000
@@ -32,6 +32,10 @@
 dnl --program-transform-name options
 AC_ARG_PROGRAM
 
+dnl It is important that variables on the RHS not be expanded here,
+dnl hence the single quotes.  This is per the GNU coding standards, see
+dnl (autoconf) Installation Directory Variables
+dnl See also epaths.h below.
 lispdir='${datadir}/emacs/${version}/lisp'
 locallisppath='${datadir}/emacs/${version}/site-lisp:'\
 '${datadir}/emacs/site-lisp'
@@ -3750,6 +3754,14 @@
 test "${exec_prefix}" != NONE &&
   exec_prefix=`echo "${exec_prefix}" | sed 's,\([^/]\)/*$,\1,'`]
 
+dnl You might wonder (I did) why epaths.h is generated by running make,
+dnl rather than just letting configure generate it from epaths.in.
+dnl One reason is that the various paths are not fully expanded (see above);
+dnl eg gamedir=${prefix}/var/games/emacs.
+dnl Secondly, the GNU Coding standards require that one should be able
+dnl to run `make prefix=/some/where/else' and override the values set
+dnl by configure.  This also explains the `move-if-change' test and
+dnl the use of force in the `epaths-force' rule in Makefile.in.
 AC_OUTPUT(Makefile lib-src/Makefile oldXMenu/Makefile \
        doc/emacs/Makefile doc/misc/Makefile doc/lispintro/Makefile \
        doc/lispref/Makefile src/Makefile \


reply via email to

[Prev in Thread] Current Thread [Next in Thread]