[Emacs-diffs] /srv/bzr/emacs/trunk r101040: * net/tramp.el (tramp-vc-registered-read-file-names): Read input

[Michael Albinus]

------------------------------------------------------------
revno: 101040
committer: Michael Albinus <address@hidden>
branch nick: trunk
timestamp: Tue 2010-08-10 11:58:15 +0200
message:
  * net/tramp.el (tramp-vc-registered-read-file-names): Read input
  as here-document, otherwise the command could exceed maximum
  length of command line.
  (tramp-handle-vc-registered): Call script accordingly.  Reported
  by Toru TSUNEYOSHI <address@hidden>.
modified:
  lisp/ChangeLog
  lisp/net/tramp.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2010-08-10 01:24:32 +0000
+++ b/lisp/ChangeLog    2010-08-10 09:58:15 +0000
@@ -1,3 +1,11 @@
+2010-08-10  Michael Albinus  <address@hidden>
+
+       * net/tramp.el (tramp-vc-registered-read-file-names): Read input
+       as here-document, otherwise the command could exceed maximum
+       length of command line.
+       (tramp-handle-vc-registered): Call script accordingly.  Reported
+       by Toru TSUNEYOSHI <address@hidden>.
+
 2010-08-10  Kenichi Handa  <address@hidden>
 
        * language/hebrew.el: Exclude U+05C3 (Hebrew SOF PASUQ) from the

=== modified file 'lisp/net/tramp.el'
--- a/lisp/net/tramp.el 2010-08-06 14:34:23 +0000
+++ b/lisp/net/tramp.el 2010-08-10 09:58:15 +0000
@@ -1983,13 +1983,13 @@
 
 (defconst tramp-vc-registered-read-file-names
   "echo \"(\"
-for file in \"address@hidden"; do
-    if %s $file; then
+while read file; do
+    if %s \"$file\"; then
        echo \"(\\\"$file\\\" \\\"file-exists-p\\\" t)\"
     else
        echo \"(\\\"$file\\\" \\\"file-exists-p\\\" nil)\"
     fi
-    if %s $file; then
+    if %s \"$file\"; then
        echo \"(\\\"$file\\\" \\\"file-readable-p\\\" t)\"
     else
        echo \"(\\\"$file\\\" \\\"file-readable-p\\\" nil)\"
@@ -1998,7 +1998,9 @@
 echo \")\""
   "Script to check existence of VC related files.
 It must be send formatted with two strings; the tests for file
-existence, and file readability.")
+existence, and file readability.  Input shall be read via
+here-document, otherwise the command could exceed maximum length
+of command line.")
 
 (defconst tramp-file-mode-type-map
   '((0  . "-")  ; Normal file (SVID-v2 and XPG2)
@@ -5419,10 +5421,10 @@
                 (tramp-send-command-and-read
                  v
                  (format
-                  "tramp_vc_registered_read_file_names %s"
+                  "tramp_vc_registered_read_file_names <<'EOF'\n%s\nEOF\n"
                   (mapconcat 'tramp-shell-quote-argument
                              tramp-vc-registered-file-names
-                             " "))))
+                             "\n"))))
 
              (tramp-set-file-property
               v (car elt) (cadr elt) (cadr (cdr elt))))))
@@ -8984,8 +8986,6 @@
 ;; * Load Tramp subpackages only when needed.  (Bug#1529, Bug#5448, Bug#5705)
 ;; * Try telnet+curl as new method.  It might be useful for busybox,
 ;;   without built-in uuencode/uudecode.
-;; * Let `shell-dynamic-complete-*' and `comint-dynamic-complete' work
-;;   on remote hosts.
 ;; * Load ~/.emacs_SHELLNAME on the remote host for `shell'.
 
 ;; Functions for file-name-handler-alist: