[Emacs-diffs] /srv/bzr/emacs/trunk r101702: Florian Ragwitz' stuff removed because of missing paperwork.

[Katsumi Yamaoka]

------------------------------------------------------------
revno: 101702
author: Lars Magne Ingebrigtsen <address@hidden>
committer: Katsumi Yamaoka <address@hidden>
branch nick: trunk
timestamp: Fri 2010-10-01 11:15:10 +0000
message:
  Florian Ragwitz' stuff removed because of missing paperwork.
modified:
  lisp/gnus/ChangeLog
  lisp/gnus/gnus-html.el
  lisp/gnus/gnus-util.el
  lisp/gnus/sieve-manage.el

=== modified file 'lisp/gnus/ChangeLog'
--- a/lisp/gnus/ChangeLog       2010-10-01 06:56:38 +0000
+++ b/lisp/gnus/ChangeLog       2010-10-01 11:15:10 +0000
@@ -1,12 +1,5 @@
 2010-10-01  Katsumi Yamaoka  <address@hidden>
 
-       * gnus-util.el (gnus-completing-read-function): Exclude
-       gnus-icompleting-read and gnus-ido-completing-read from candidates for
-       XEmacs since iswitchb.el is very old and ido.el is unavailable in
-       XEmacs.
-       (iswitchb-mode, iswitchb-temp-buflist, iswitchb-read-buffer): Silence
-       the byte compiler.
-
        * gravatar.el: Don't load image.el that XEmacs doesn't provide.
        (gravatar-create-image): New function that's an alias to
        gnus-xmas-create-image, gnus-create-image, or create-image.
@@ -143,17 +136,6 @@
        `gnus-faces-properties-alist'.
        Add :version property.
 
-2010-09-28  Florian Ragwitz  <address@hidden>
-
-       * gnus-util.el (gnus-use-ido): Removed.
-       (gnus-std-completing-read): Add wrapper around completing-read.
-       (gnus-icompleting-read): Add wrapper around ibuffer-read-buffer.
-       (gnus-ido-completing-read): Add wrapper around ido-completing-read.
-       (gnus-completing-read-function): Add to chose from the above completion
-       functions or to provide a custom one.
-       (gnus-completing-read): Use the completing-read function configured
-       with gnus-completing-read-function.
-
 2010-09-28  Katsumi Yamaoka  <address@hidden>
 
        * mail-source.el (mail-source-report-new-mail)
@@ -317,11 +299,6 @@
        discover we're on a STARTTLS-capable server, then open a STARTTLS
        connection instead.
 
-2010-09-27  Florian Ragwitz  <address@hidden>  (tiny change)
-
-       * sieve-manage.el (sieve-manage-default-stream): Make default stream
-       customizable.
-
 2010-09-27  Lars Magne Ingebrigtsen  <address@hidden>
 
        * nnimap.el (utf7): Required.
@@ -342,11 +319,6 @@
 
        * gnus-art.el (gnus-mime-delete-part): Fix Lisp type of byte(s).
 
-2010-09-26  Florian Ragwitz  <address@hidden>  (tiny change)
-
-       * gnus-html.el (gnus-html-wash-tags): Decode URL entities to avoid
-       handing broken links to browse-url.
-
 2010-09-26  Lars Magne Ingebrigtsen  <address@hidden>
 
        * nndoc.el (nndoc-request-list): Return success always.

=== modified file 'lisp/gnus/gnus-html.el'
--- a/lisp/gnus/gnus-html.el    2010-09-27 12:22:22 +0000
+++ b/lisp/gnus/gnus-html.el    2010-10-01 11:15:10 +0000
@@ -286,7 +286,7 @@
          (setq url (match-string 1 parameters))
           (gnus-message 8 "gnus-html-wash-tags: fetching link URL %s" url)
          (gnus-article-add-button start end
-                                  'browse-url (mm-url-decode-entities-string 
url)
+                                  'browse-url url
                                   url)
          (let ((overlay (gnus-make-overlay start end)))
            (gnus-overlay-put overlay 'evaporate t)

=== modified file 'lisp/gnus/gnus-util.el'
--- a/lisp/gnus/gnus-util.el    2010-10-01 06:56:38 +0000
+++ b/lisp/gnus/gnus-util.el    2010-10-01 11:15:10 +0000
@@ -44,21 +44,11 @@
     (defmacro with-no-warnings (&rest body)
       `(progn ,@body))))
 
-(defcustom gnus-completing-read-function
-  #'gnus-std-completing-read
-  "Function to do a completing read."
+(defcustom gnus-use-ido nil
+  "Whether to use `ido' for `completing-read'."
+  :version "24.1"
   :group 'gnus-meta
-  :type `(radio (function-item
-                 :doc "Use Emacs' standard `completing-read' function."
-                 gnus-std-completing-read)
-               ,@(unless (featurep 'xemacs)
-                   '((function-item
-                      :doc "Use iswitchb's completing-read function."
-                      gnus-icompleting-read)
-                     (function-item
-                      :doc "Use ido's completing-read function."
-                      gnus-ido-completing-read)))
-                (function)))
+  :type 'boolean)
 
 (defcustom gnus-completion-styles
   (if (and (boundp 'completion-styles-alist)
@@ -1593,55 +1583,19 @@
        `(,(car spec) ,@(mapcar 'gnus-make-predicate-1 (cdr spec)))
       (error "Invalid predicate specifier: %s" spec)))))
 
-(defun gnus-std-completing-read (prompt collection &optional require-match
-                                        initial-input history def)
-  (completing-read prompt collection nil require-match
-                   initial-input history def))
-
-(defvar iswitchb-mode)
-(defvar iswitchb-temp-buflist)
-(declare-function iswitchb-read-buffer "iswitchb"
-                 (prompt &optional default require-match start matches-set))
-
-(defun gnus-icompleting-read (prompt collection &optional require-match
-                                     initial-input history def)
-  (require 'iswitchb)
-  (let ((iswitchb-make-buflist-hook
-         (lambda ()
-           (setq iswitchb-temp-buflist
-                 (let ((choices (append (list)
-                                        (when initial-input (list 
initial-input))
-                                        (symbol-value history) collection))
-                       filtered-choices)
-                   (while choices
-                     (when (and (car choices) (not (member (car choices) 
filtered-choices)))
-                       (setq filtered-choices (cons (car choices) 
filtered-choices)))
-                     (setq choices (cdr choices)))
-                   (nreverse filtered-choices))))))
-    (unwind-protect
-        (progn
-          (when (not iswitchb-mode)
-            (add-hook 'minibuffer-setup-hook 'iswitchb-minibuffer-setup))
-          (iswitchb-read-buffer prompt def require-match))
-      (when (not iswitchb-mode)
-        (remove-hook 'minibuffer-setup-hook 'iswitchb-minibuffer-setup)))))
-
-(defun gnus-ido-completing-read (prompt collection &optional require-match
-                                        initial-input history def)
-  (require 'ido)
-  (ido-completing-read prompt collection nil require-match
-                       initial-input history def))
-
 (defun gnus-completing-read (prompt collection &optional require-match
                                     initial-input history def)
-  "Do a completing read with the configured `gnus-completing-read-function'."
+  "Call `completing-read' or `ido-completing-read'.
+Depends on `gnus-use-ido'."
   (let ((completion-styles gnus-completion-styles))
     (funcall
-     gnus-completing-read-function
+     (if gnus-use-ido
+         'ido-completing-read
+       'completing-read)
      (concat prompt (when def
                       (concat " (default " def ")"))
              ": ")
-     collection require-match initial-input history def)))
+     collection nil require-match initial-input history def)))
 
 (defun gnus-graphic-display-p ()
   (if (featurep 'xemacs)

=== modified file 'lisp/gnus/sieve-manage.el'
--- a/lisp/gnus/sieve-manage.el 2010-09-27 23:07:47 +0000
+++ b/lisp/gnus/sieve-manage.el 2010-10-01 11:15:10 +0000
@@ -162,12 +162,6 @@
   :type 'integer
   :group 'sieve-manage)
 
-(defcustom sieve-manage-default-stream 'network
-  "Default stream type to use for `sieve-manage'.
-Must be a name of a stream in `sieve-manage-stream-alist'."
-  :type 'symbol
-  :group 'sieve-manage)
-
 ;; Internal variables:
 
 (defconst sieve-manage-local-variables '(sieve-manage-server
@@ -180,6 +174,7 @@
                                         sieve-manage-client-eol
                                         sieve-manage-server-eol
                                         sieve-manage-capability))
+(defconst sieve-manage-default-stream 'network)
 (defconst sieve-manage-coding-system-for-read 'binary)
 (defconst sieve-manage-coding-system-for-write 'binary)
 (defvar sieve-manage-stream nil)