[Emacs-diffs] /srv/bzr/emacs/trunk r104935: * play/animate.el (animate-string): Doc fixes and allow changing

[Lars Magne Ingebrigtsen]

------------------------------------------------------------
revno: 104935
fixes bug(s): http://debbugs.gnu.org/5417
author: MON KEY <address@hidden>
committer: Lars Magne Ingebrigtsen <address@hidden>
branch nick: trunk
timestamp: Mon 2011-07-04 13:44:36 +0200
message:
  * play/animate.el (animate-string): Doc fixes and allow changing
  the buffer name.
modified:
  lisp/ChangeLog
  lisp/play/animate.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2011-07-04 06:31:40 +0000
+++ b/lisp/ChangeLog    2011-07-04 11:44:36 +0000
@@ -1,3 +1,12 @@
+2011-07-04  MON KEY  <address@hidden>
+
+       * play/animate.el (animate-string): Doc fixes and allow changing
+       the buffer name (bug#5417).
+
+2011-07-04  Lars Magne Ingebrigtsen  <address@hidden>
+
+       * play/animate.el (animation-buffer-name): Renamed from *animate*.
+
 2011-07-04  Paul Eggert  <address@hidden>
 
        * emacs-lisp/timer.el: Use time-date fns rather than rolling our own.

=== modified file 'lisp/play/animate.el'
--- a/lisp/play/animate.el      2011-01-25 04:08:28 +0000
+++ b/lisp/play/animate.el      2011-07-04 11:44:36 +0000
@@ -89,11 +89,15 @@
   (insert-char char 1))
 
 (defvar animate-n-steps 10
-  "Number of steps to use `animate-string'.")
+"*Number of steps `animate-string' will place a char before its last 
position.")
+
+(defvar animation-buffer-name nil
+  "*String naming the default buffer for animations.
+When nil animations dipslayed in the buffer named *Animation*.")
 
 ;;;###autoload
 (defun animate-string (string vpos &optional hpos)
-  "Display STRING starting at position VPOS, HPOS, using animation.
+  "Display STRING animations starting at position VPOS, HPOS.
 The characters start at randomly chosen places,
 and all slide in parallel to their final positions,
 passing through `animate-n-steps' positions before the final ones.
@@ -138,14 +142,19 @@
 
 ;;;###autoload
 (defun animate-sequence (list-of-strings space)
-  "Display strings from LIST-OF-STRING with animation in a new buffer.
-Strings will be separated from each other by SPACE lines."
+  "Display animation strings from LIST-OF-STRING with buffer *Animation*.
+Strings will be separated from each other by SPACE lines.
+ When the variable `animation-buffer-name' is non-nil display
+animation in the buffer named by variable's value, creating the
+buffer if one does not exist."
   (let ((vpos (/ (- (window-height)
                    1 ;; For the mode-line
                    (* (1- (length list-of-strings)) space)
                    (length list-of-strings))
                 2)))
-    (switch-to-buffer (get-buffer-create "*Animation*"))
+    (switch-to-buffer (get-buffer-create
+                       (or animation-buffer-name
+                           "*Animation*")))
     (erase-buffer)
     (sit-for 0)
     (while list-of-strings
@@ -155,19 +164,25 @@
 
 ;;;###autoload
 (defun animate-birthday-present (&optional name)
-  "Display one's birthday present in a new buffer.
-You can specify the one's name by NAME; the default value is \"Sarah\"."
-  (interactive (list (read-string "Name (default Sarah): "
-                                 nil nil "Sarah")))
+  "Return a birthday present in the buffer *Birthday-Present*.
+When optional arg NAME is non-nil or called-interactively, prompt for
+NAME of birthday present receiver and return a birthday present in
+the buffer *Birthday-Present-for-Name*."
+  (interactive (list (read-string "Birthday present for: "
+                                 nil nil)))
   ;; Make a suitable buffer to display the birthday present in.
-  (switch-to-buffer (get-buffer-create (format "*%s*" name)))
+  (switch-to-buffer (get-buffer-create
+                    (if name
+                        (concat "*A-Present-for-" (capitalize name) "*")
+                      "*Birthday-Present*")))
   (erase-buffer)
   ;; Display the empty buffer.
   (sit-for 0)
 
-  (animate-string "Happy Birthday," 6)
-  (animate-string (format "%s" name) 7)
-
+  (if name
+      (animate-string "Happy Birthday," 6)
+      (animate-string "Happy Birthday" 6))
+  (when name (animate-string (format "%s" (capitalize name)) 7))
   (sit-for 1)
 
   (animate-string "You are my sunshine," 10 30)