emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r106869: Fix bug #9087 with crashes o


From: Eli Zaretskii
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r106869: Fix bug #9087 with crashes on MS-Windows under throw-on-input.
Date: Sat, 14 Jan 2012 22:15:01 +0200
User-agent: Bazaar (2.3.1)

------------------------------------------------------------
revno: 106869
fixes bug(s): http://debbugs.gnu.org/9087
committer: Eli Zaretskii <address@hidden>
branch nick: trunk
timestamp: Sat 2012-01-14 22:15:01 +0200
message:
  Fix bug #9087 with crashes on MS-Windows under throw-on-input.
  
   src/w32fns.c (signal_user_input): Don't do a QUIT, to avoid
   thrashing the stack of the thread.
modified:
  src/ChangeLog
  src/w32fns.c
=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2012-01-12 21:33:25 +0000
+++ b/src/ChangeLog     2012-01-14 20:15:01 +0000
@@ -1,3 +1,8 @@
+2012-01-14  Eli Zaretskii  <address@hidden>
+
+       * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
+       thrashing the stack of the thread.  (Bug#9087)
+
 2012-01-12  Paul Eggert  <address@hidden>
 
        * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.

=== modified file 'src/w32fns.c'
--- a/src/w32fns.c      2012-01-05 09:46:05 +0000
+++ b/src/w32fns.c      2012-01-14 20:15:01 +0000
@@ -2479,6 +2479,10 @@
   if (!NILP (Vthrow_on_input))
     {
       Vquit_flag = Vthrow_on_input;
+      /* Doing a QUIT from this thread is a bad idea, since this
+        unwinds the stack of the Lisp thread, and the Windows runtime
+        rightfully barfs.  Disabled.  */
+#if 0
       /* If we're inside a function that wants immediate quits,
         do it now.  */
       if (immediate_quit && NILP (Vinhibit_quit))
@@ -2486,6 +2490,7 @@
          immediate_quit = 0;
          QUIT;
        }
+#endif
     }
 }
 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]