emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] /srv/bzr/emacs/trunk r107090: When changing frame sizes ro


From: martin rudalics
Subject: [Emacs-diffs] /srv/bzr/emacs/trunk r107090: When changing frame sizes round before applying new sizes. (Bug#9723)
Date: Sat, 04 Feb 2012 12:29:29 +0100
User-agent: Bazaar (2.3.1)

------------------------------------------------------------
revno: 107090
committer: martin rudalics <address@hidden>
branch nick: trunk
timestamp: Sat 2012-02-04 12:29:29 +0100
message:
  When changing frame sizes round before applying new sizes.  (Bug#9723) 
  
  * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
  after rounding frame sizes.  (Bug#9723)
modified:
  src/ChangeLog
  src/dispnew.c
=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2012-02-04 09:27:03 +0000
+++ b/src/ChangeLog     2012-02-04 11:29:29 +0000
@@ -1,3 +1,8 @@
+2012-02-04  Martin Rudalics  <address@hidden>
+
+       * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
+       after rounding frame sizes.  (Bug#9723)
+
 2012-02-04  Eli Zaretskii  <address@hidden>
 
        * keyboard.c (adjust_point_for_property): Don't position point

=== modified file 'src/dispnew.c'
--- a/src/dispnew.c     2012-01-19 07:21:25 +0000
+++ b/src/dispnew.c     2012-02-04 11:29:29 +0000
@@ -5761,19 +5761,22 @@
   if (newwidth == 0)
     newwidth  = FRAME_COLS  (f);
 
-  /* Compute width of windows in F.
-     This is the width of the frame without vertical scroll bars.  */
-  new_frame_total_cols = FRAME_TOTAL_COLS_ARG (f, newwidth);
-
+  /* Compute width of windows in F.  */
   /* Round up to the smallest acceptable size.  */
   check_frame_size (f, &newheight, &newwidth);
 
+  /* This is the width of the frame with vertical scroll bars and fringe
+     columns.  Do this after rounding - see discussion of bug#9723.  */
+  new_frame_total_cols = FRAME_TOTAL_COLS_ARG (f, newwidth);
+
   /* If we're not changing the frame size, quit now.  */
-  /* Frame width may be unchanged but the text portion may change, for example,
-     fullscreen and remove/add scroll bar.  */
+  /* Frame width may be unchanged but the text portion may change, for
+     example, fullscreen and remove/add scroll bar.  */
   if (newheight == FRAME_LINES (f)
-      && newwidth == FRAME_COLS  (f) // text portion unchanged
-      && new_frame_total_cols == FRAME_TOTAL_COLS (f)) // frame width unchanged
+      /* Text portion unchanged?  */
+      && newwidth == FRAME_COLS  (f)
+      /* Frame width unchanged?  */
+      && new_frame_total_cols == FRAME_TOTAL_COLS (f))
     return;
 
   BLOCK_INPUT;


reply via email to

[Prev in Thread] Current Thread [Next in Thread]