emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107428: * doc/lispref/files.texi


From: Stefan Monnier
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107428: * doc/lispref/files.texi: (files-equal-p, file-subdir-of-p): Add documentation.
Date: Sun, 26 Feb 2012 16:33:57 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux)

>> That's a current limitation, and might be lifted in the future.
>> Maybe dir2's existence is a prerequisite, but "a/b/c" is a subdir of "a"
>> whether or not "a/b" exists, so I don't think we should force dir1 to exist.
> In this case the comparison have to be with string= but no more with
> files-equal-p (files-attributes).

Not necessarily.  We can start we a loop like (while (not
(file-directory-p dir1)) (setq dir1 (file-name-directory dir1))).

>>> +otherwise, return nil.
>> And at least we should not force our function to return nil when
>> encountering that limitation, since it means we can't lift this
>> limitation without breaking documented behavior.
> What do you want to return instead?

What we return doesn't matter as much as the fact we don't want code to
rely on it, so we want to say that in that case the returned value
is unspecified.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]