[Emacs-diffs] /srv/bzr/emacs/trunk r108762: Replace eshell-defgroup with plain defgroup

[Glenn Morris]

------------------------------------------------------------
revno: 108762
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Wed 2012-06-27 00:08:06 -0700
message:
  Replace eshell-defgroup with plain defgroup
  
  Borrowing a trick from vc-sccs.el, wrap the defgroup in a progn
  so that the whole thing ends up in the generated autoload file,
  esh-groups.el.
  
  * em-alias.el, em-banner.el, em-basic.el, em-cmpl.el, em-dirs.el:
  * em-glob.el, em-hist.el, em-ls.el, em-pred.el, em-prompt.el:
  * em-rebind.el, em-script.el, em-smart.el, em-term.el, em-unix.el:
  * em-xtra.el: Replace eshell-defgroup with (progn (defgroup.
  * eshell.el (eshell-defgroup): Remove alias.
modified:
  lisp/ChangeLog
  lisp/eshell/em-alias.el
  lisp/eshell/em-banner.el
  lisp/eshell/em-basic.el
  lisp/eshell/em-cmpl.el
  lisp/eshell/em-dirs.el
  lisp/eshell/em-glob.el
  lisp/eshell/em-hist.el
  lisp/eshell/em-ls.el
  lisp/eshell/em-pred.el
  lisp/eshell/em-prompt.el
  lisp/eshell/em-rebind.el
  lisp/eshell/em-script.el
  lisp/eshell/em-smart.el
  lisp/eshell/em-term.el
  lisp/eshell/em-unix.el
  lisp/eshell/em-xtra.el
  lisp/eshell/esh-module.el
  lisp/eshell/eshell.el

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2012-06-27 05:47:14 +0000
+++ b/lisp/ChangeLog    2012-06-27 07:08:06 +0000
@@ -1,3 +1,13 @@
+2012-06-27  Glenn Morris  <address@hidden>
+
+       * eshell/em-alias.el, eshell/em-banner.el, eshell/em-basic.el:
+       * eshell/em-cmpl.el, eshell/em-dirs.el, eshell/em-glob.el:
+       * eshell/em-hist.el, eshell/em-ls.el, eshell/em-pred.el:
+       * eshell/em-prompt.el, eshell/em-rebind.el, eshell/em-script.el:
+       * eshell/em-smart.el, eshell/em-term.el, eshell/em-unix.el:
+       * eshell/em-xtra.el: Replace eshell-defgroup with "(progn (defgroup".
+       * eshell/eshell.el (eshell-defgroup): Remove alias.
+
 2012-06-27  Chong Yidong  <address@hidden>
 
        * help.el (help-enable-auto-load): New variable.

=== modified file 'lisp/eshell/em-alias.el'
--- a/lisp/eshell/em-alias.el   2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-alias.el   2012-06-27 07:08:06 +0000
@@ -95,11 +95,12 @@
 (require 'eshell)
 
 ;;;###autoload
-(eshell-defgroup eshell-alias nil
+(progn
+(defgroup eshell-alias nil
   "Command aliases allow for easy definition of alternate commands."
   :tag "Command aliases"
   ;; :link '(info-link "(eshell)Command aliases")
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 (defcustom eshell-aliases-file (expand-file-name "alias" eshell-directory-name)
   "The file in which aliases are kept.

=== modified file 'lisp/eshell/em-banner.el'
--- a/lisp/eshell/em-banner.el  2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-banner.el  2012-06-27 07:08:06 +0000
@@ -46,13 +46,14 @@
 (require 'esh-util)
 
 ;;;###autoload
-(eshell-defgroup eshell-banner nil
+(progn
+(defgroup eshell-banner nil
   "This sample module displays a welcome banner at login.
 It exists so that others wishing to create their own Eshell extension
 modules may have a simple template to begin with."
   :tag "Login banner"
   ;; :link '(info-link "(eshell)Login banner")
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-basic.el'
--- a/lisp/eshell/em-basic.el   2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-basic.el   2012-06-27 07:08:06 +0000
@@ -66,14 +66,15 @@
 (require 'esh-opt)
 
 ;;;###autoload
-(eshell-defgroup eshell-basic nil
+(progn
+(defgroup eshell-basic nil
   "The \"basic\" code provides a set of convenience functions which
 are traditionally considered shell builtins.  Since all of the
 functionality provided by them is accessible through Lisp, they are
 not really builtins at all, but offer a command-oriented way to do the
 same thing."
   :tag "Basic shell commands"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 (defcustom eshell-plain-echo-behavior nil
   "If non-nil, `echo' tries to behave like an ordinary shell echo.

=== modified file 'lisp/eshell/em-cmpl.el'
--- a/lisp/eshell/em-cmpl.el    2012-03-05 10:44:31 +0000
+++ b/lisp/eshell/em-cmpl.el    2012-06-27 07:08:06 +0000
@@ -75,12 +75,13 @@
 (require 'esh-util)
 
 ;;;###autoload
-(eshell-defgroup eshell-cmpl nil
+(progn
+(defgroup eshell-cmpl nil
   "This module provides a programmable completion function bound to
 the TAB key, which allows for completing command names, file names,
 variable names, arguments, etc."
   :tag "Argument completion"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-dirs.el'
--- a/lisp/eshell/em-dirs.el    2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-dirs.el    2012-06-27 07:08:06 +0000
@@ -47,14 +47,15 @@
 (require 'esh-opt)
 
 ;;;###autoload
-(eshell-defgroup eshell-dirs nil
+(progn
+(defgroup eshell-dirs nil
   "Directory navigation involves changing directories, examining the
 current directory, maintaining a directory stack, and also keeping
 track of a history of the last directory locations the user was in.
 Emacs does provide standard Lisp definitions of `pwd' and `cd', but
 they lack somewhat in feel from the typical shell equivalents."
   :tag "Directory navigation"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-glob.el'
--- a/lisp/eshell/em-glob.el    2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-glob.el    2012-06-27 07:08:06 +0000
@@ -53,11 +53,12 @@
 (require 'esh-util)
 
 ;;;###autoload
-(eshell-defgroup eshell-glob nil
+(progn
+(defgroup eshell-glob nil
   "This module provides extended globbing syntax, similar what is used
 by zsh for filename generation."
   :tag "Extended filename globbing"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-hist.el'
--- a/lisp/eshell/em-hist.el    2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-hist.el    2012-06-27 07:08:06 +0000
@@ -63,10 +63,11 @@
 (require 'eshell)
 
 ;;;###autoload
-(eshell-defgroup eshell-hist nil
+(progn
+(defgroup eshell-hist nil
   "This module provides command history management."
   :tag "History list management"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-ls.el'
--- a/lisp/eshell/em-ls.el      2012-02-11 22:13:29 +0000
+++ b/lisp/eshell/em-ls.el      2012-06-27 07:08:06 +0000
@@ -33,14 +33,15 @@
 (require 'esh-opt)
 
 ;;;###autoload
-(eshell-defgroup eshell-ls nil
+(progn
+(defgroup eshell-ls nil
   "This module implements the \"ls\" utility fully in Lisp.  If it is
 passed any unrecognized command switches, it will revert to the
 operating system's version.  This version of \"ls\" uses text
 properties to colorize its output based on the setting of
 `eshell-ls-use-colors'."
   :tag "Implementation of `ls' in Lisp"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-pred.el'
--- a/lisp/eshell/em-pred.el    2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-pred.el    2012-06-27 07:08:06 +0000
@@ -49,13 +49,14 @@
 (eval-when-compile (require 'eshell))
 
 ;;;###autoload
-(eshell-defgroup eshell-pred nil
+(progn
+(defgroup eshell-pred nil
   "This module allows for predicates to be applied to globbing
 patterns (similar to zsh), in addition to string modifiers which can
 be applied either to globbing results, variable references, or just
 ordinary strings."
   :tag "Value modifiers and predicates"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-prompt.el'
--- a/lisp/eshell/em-prompt.el  2012-06-08 16:39:49 +0000
+++ b/lisp/eshell/em-prompt.el  2012-06-27 07:08:06 +0000
@@ -29,11 +29,12 @@
 (eval-when-compile (require 'eshell))
 
 ;;;###autoload
-(eshell-defgroup eshell-prompt nil
+(progn
+(defgroup eshell-prompt nil
   "This module provides command prompts, and navigation between them,
 as is common with most shells."
   :tag "Command prompts"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-rebind.el'
--- a/lisp/eshell/em-rebind.el  2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-rebind.el  2012-06-27 07:08:06 +0000
@@ -26,7 +26,8 @@
 (eval-when-compile (require 'eshell))
 
 ;;;###autoload
-(eshell-defgroup eshell-rebind nil
+(progn
+(defgroup eshell-rebind nil
   "This module allows for special keybindings that only take effect
 while the point is in a region of input text.  By default, it binds
 C-a to move to the beginning of the input text (rather than just the
@@ -37,7 +38,7 @@
 `backward-word', `previous-line', etc.  This module intends to mimic
 the behavior of normal shells while the user editing new input text."
   :tag "Rebind keys at input"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-script.el'
--- a/lisp/eshell/em-script.el  2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-script.el  2012-06-27 07:08:06 +0000
@@ -26,11 +26,12 @@
 (require 'eshell)
 
 ;;;###autoload
-(eshell-defgroup eshell-script nil
+(progn
+(defgroup eshell-script nil
   "This module allows for the execution of files containing Eshell
 commands, as a script file."
   :tag "Running script files."
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-smart.el'
--- a/lisp/eshell/em-smart.el   2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-smart.el   2012-06-27 07:08:06 +0000
@@ -71,7 +71,8 @@
 (eval-when-compile (require 'eshell))
 
 ;;;###autoload
-(eshell-defgroup eshell-smart nil
+(progn
+(defgroup eshell-smart nil
   "This module combines the facility of normal, modern shells with
 some of the edit/review concepts inherent in the design of Plan 9's
 9term.  See the docs for more details.
@@ -80,7 +81,7 @@
 it to get a real sense of how it works."
   :tag "Smart display of output"
   ;; :link '(info-link "(eshell)Smart display of output")
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-term.el'
--- a/lisp/eshell/em-term.el    2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/em-term.el    2012-06-27 07:08:06 +0000
@@ -35,14 +35,15 @@
 (require 'term)
 
 ;;;###autoload
-(eshell-defgroup eshell-term nil
+(progn
+(defgroup eshell-term nil
   "This module causes visual commands (e.g., 'vi') to be executed by
 the `term' package, which comes with Emacs.  This package handles most
 of the ANSI control codes, allowing curses-based applications to run
 within an Emacs window.  The variable `eshell-visual-commands' defines
 which commands are considered visual in nature."
   :tag "Running visual commands"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; User Variables:
 

=== modified file 'lisp/eshell/em-unix.el'
--- a/lisp/eshell/em-unix.el    2012-02-28 08:17:21 +0000
+++ b/lisp/eshell/em-unix.el    2012-06-27 07:08:06 +0000
@@ -40,7 +40,8 @@
 (require 'pcomplete)
 
 ;;;###autoload
-(eshell-defgroup eshell-unix nil
+(progn
+(defgroup eshell-unix nil
   "This module defines many of the more common UNIX utilities as
 aliases implemented in Lisp.  These include mv, ln, cp, rm, etc.  If
 the user passes arguments which are too complex, or are unrecognized
@@ -51,7 +52,7 @@
 \(such as being able to use `kill' to kill Eshell background processes
 by name)."
   :tag "UNIX commands in Lisp"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 (defcustom eshell-unix-load-hook nil
   "A list of functions to run when `eshell-unix' is loaded."

=== modified file 'lisp/eshell/em-xtra.el'
--- a/lisp/eshell/em-xtra.el    2012-02-28 08:17:21 +0000
+++ b/lisp/eshell/em-xtra.el    2012-06-27 07:08:06 +0000
@@ -29,13 +29,14 @@
 (require 'compile)
 
 ;;;###autoload
-(eshell-defgroup eshell-xtra nil
+(progn
+(defgroup eshell-xtra nil
   "This module defines some extra alias functions which are entirely
 optional.  They can be viewed as samples for how to write Eshell alias
 functions, or as aliases which make some of Emacs's behavior more
 naturally accessible within Emacs."
   :tag "Extra alias functions"
-  :group 'eshell-module)
+  :group 'eshell-module))
 
 ;;; Functions:
 

=== modified file 'lisp/eshell/esh-module.el'
--- a/lisp/eshell/esh-module.el 2012-01-19 07:21:25 +0000
+++ b/lisp/eshell/esh-module.el 2012-06-27 07:08:06 +0000
@@ -36,7 +36,9 @@
 
 ;; load the defgroup's for the standard extension modules, so that
 ;; documentation can be provided when the user customize's
-;; `eshell-modules-list'.
+;; `eshell-modules-list'.  We use "(progn (defgroup ..." in each file
+;; to force the autoloader into including the entire defgroup, rather
+;; than an abbreviated version.
 (load "esh-groups" nil 'nomessage)
 
 ;;; User Variables:

=== modified file 'lisp/eshell/eshell.el'
--- a/lisp/eshell/eshell.el     2012-04-22 13:58:00 +0000
+++ b/lisp/eshell/eshell.el     2012-06-27 07:08:06 +0000
@@ -236,10 +236,6 @@
   :version "21.1"
   :group 'applications)
 
-;; This is hack to force make-autoload to put the whole definition
-;; into the autoload file (see esh-module.el).
-(defalias 'eshell-defgroup 'defgroup)
-
 ;;;_* User Options
 ;;
 ;; The following user options modify the behavior of Eshell overall.