[Emacs-diffs] /srv/bzr/emacs/trunk r108987: * src/s/gnu.h: Don't include fcntl.h

[Glenn Morris]

------------------------------------------------------------
revno: 108987
committer: Glenn Morris <address@hidden>
branch nick: trunk
timestamp: Mon 2012-07-09 21:33:53 -0400
message:
  * src/s/gnu.h: Don't include fcntl.h
  (every file in Emacs that uses O_RDONLY already includes it; and this
  does not seem like the problem a src/s file should be trying to solve).
modified:
  src/ChangeLog
  src/s/gnu.h

=== modified file 'src/ChangeLog'
--- a/src/ChangeLog     2012-07-10 01:04:28 +0000
+++ b/src/ChangeLog     2012-07-10 01:33:53 +0000
@@ -1,5 +1,8 @@
 2012-07-10  Glenn Morris  <address@hidden>
 
+       * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
+       O_RDONLY already includes it).
+
        Stop ns builds setting the EMACSLOADPATH environment variable.
        * nsterm.m (ns_load_path): Rename from ns_init_paths.
        Now it does not set EMACSLOADPATH, just returns the load-path string.

=== modified file 'src/s/gnu.h'
--- a/src/s/gnu.h       2012-07-09 23:23:59 +0000
+++ b/src/s/gnu.h       2012-07-10 01:33:53 +0000
@@ -24,10 +24,7 @@
 /* libc defines data_start.  */
 #define DATA_START ({ extern int data_start; (char *) &data_start; })
 
-/* Some losing code fails to include this and then assumes
-   that because it is braindead that O_RDONLY==0.  */
-#include <fcntl.h>
-
+/* It would be harmless to drop the ifdef emacs test.  */
 #ifdef emacs
 #include <stdio.h>  /* Get the definition of _IO_STDIO_H.  */
 #if defined (_IO_STDIO_H) || defined (_STDIO_USES_IOSTREAM)