Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109646: In window.el tell whether functions operate on valid, live or any windows.

[Liang Wang]

On Fri, Aug 17, 2012 at 1:22 AM, martin rudalics <address@hidden> wrote:
> ------------------------------------------------------------
> revno: 109646
> committer: martin rudalics <address@hidden>
> branch nick: trunk
> timestamp: Thu 2012-08-16 19:22:36 +0200
> message:
>   In window.el tell whether functions operate on valid, live or any windows.
>
>   * window.el (window-child, window-child-count, window-last-child)
>   (window-normalize-window, window-combined-p)
>   (window-combinations, window-atom-root, window-min-size)
>   (window-sizable, window-sizable-p, window-size-fixed-p)
>   (window-min-delta, window-max-delta, window--resizable)
>   (window--resizable-p, window-resizable, window-total-size)
>   (window-full-height-p, window-full-width-p, window-body-size)
>   (window-at-side-p, adjust-window-trailing-edge, maximize-window)
>   (minimize-window, window-deletable-p, delete-window)
>   (delete-other-windows, set-window-buffer-start-and-point)
>   (next-buffer, previous-buffer, split-window, balance-windows-2)
>   (set-window-text-height, window-buffer-height)
>   (fit-window-to-buffer, shrink-window-if-larger-than-buffer)
>   (truncated-partial-width-window-p): Minor code adjustments.  In
>   doc-strings state whether the argument window has to denote a
>   live, valid or any window.
> modified:
>   lisp/ChangeLog
>   lisp/window.el
>

> @@ -2419,8 +2429,9 @@
>
>  Otherwise, if WINDOW is part of an atomic window, call
>  `delete-window' with the root of the atomic window as its
> -argument.  If WINDOW is the only window on its frame or the last
> -non-side window, signal an error."
> +argument.  Signal an error if WINDOW is either the only window on
> +its frame, the last non-side window, or part of an atomic window
> +that is its frame's root window."
>    (interactive)
>    (setq window (window-normalize-window window))
>    (let* ((frame (window-frame window))
> @@ -2448,7 +2459,9 @@
>                  (not (eq (window-parameter parent 'window-side) 'none))))
>         (error "Attempt to delete last non-side window"))
>         ((not parent)
> -       (error "Attempt to delete minibuffer or sole ordinary window")))
> +       (error "Attempt to delete minibuffer or sole ordinary window"))
> +       ((eq window (window--major-non-side-window frame))
> +       (error "Attempt to delete last non-side window")))

I get an error as
byte-code: Symbol's function definition is void: window--major-non-side-window

Liang

>
>        (let* ((horizontal (window-left-child parent))
>              (size (window-total-size window horizontal))