emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112107: * frame.h (struct frame)


From: Eli Zaretskii
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r112107: * frame.h (struct frame): Put menu_bar_window under #ifdef
Date: Fri, 22 Mar 2013 18:09:12 +0200

> --- a/src/dispnew.c   2013-03-20 11:29:37 +0000
> +++ b/src/dispnew.c   2013-03-22 12:41:34 +0000
> @@ -794,11 +794,13 @@
>    if (f->current_matrix)
>      clear_glyph_matrix (f->current_matrix);
>  
> +#if defined (HAVE_X_WINDOWS) && ! defined (USE_X_TOOLKIT) && ! defined 
> (USE_GTK)
>    /* Clear the matrix of the menu bar window, if such a window exists.
>       The menu bar window is currently used to display menus on X when
>       no toolkit support is compiled in.  */
>    if (WINDOWP (f->menu_bar_window))
>      clear_glyph_matrix (XWINDOW (f->menu_bar_window)->current_matrix);
> +#endif
>  

What about w32 and NS?  Why not just use #ifdef HAVE_WINDOW_SYSTEM?
For that matter, why ifdef this away at all?  On a TTY,
menu_bar_window is not a window, so the call to clear_glyph_matrix is
never made anyway.

Or am I missing something?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]