[Emacs-diffs] trunk r114879: * semantic/idle.el (semantic-idle-symbol-highlight)

[Barry O'Reilly]

------------------------------------------------------------
revno: 114879
revision-id: address@hidden
parent: address@hidden
fixes bug: http://debbugs.gnu.org/15745
committer: Barry O'Reilly <address@hidden>
branch nick: trunk
timestamp: Wed 2013-10-30 21:50:24 -0400
message:
  * semantic/idle.el (semantic-idle-symbol-highlight)
  (semantic-idle-symbol-highlight-face): Define face with defface
  and obsolete the replaced one defined with defvar.  (Bug#15745)
  * pulse.el (pulse-momentary-highlight-overlay)
  (pulse-momentary-highlight-region): Fix typo in doc
modified:
  lisp/cedet/ChangeLog           changelog-20100919015713-3rbr456yray5m84f-1
  lisp/cedet/pulse.el            pulse.el-20091113204419-o5vbwnq5f7feedwu-10981
  lisp/cedet/semantic/idle.el    idle.el-20091113204419-o5vbwnq5f7feedwu-11285

=== modified file 'lisp/cedet/ChangeLog'
--- a/lisp/cedet/ChangeLog      2013-10-30 06:31:15 +0000
+++ b/lisp/cedet/ChangeLog      2013-10-31 01:50:24 +0000
@@ -1,3 +1,11 @@
+2013-10-28  Barry O'Reilly  <address@hidden>
+
+       * semantic/idle.el (semantic-idle-symbol-highlight)
+       (semantic-idle-symbol-highlight-face): Define face with defface
+       and obsolete the replaced one defined with defvar.  (Bug#15745)
+       * pulse.el (pulse-momentary-highlight-overlay)
+       (pulse-momentary-highlight-region): Fix typo in doc
+
 2013-10-30  Glenn Morris  <address@hidden>
 
        * semantic/grammar.el (semantic-grammar-mode-keywords-2)

=== modified file 'lisp/cedet/pulse.el'
--- a/lisp/cedet/pulse.el       2013-01-01 09:11:05 +0000
+++ b/lisp/cedet/pulse.el       2013-10-31 01:50:24 +0000
@@ -180,7 +180,7 @@
 
 (defun pulse-momentary-highlight-overlay (o &optional face)
   "Pulse the overlay O, unhighlighting before next command.
-Optional argument FACE specifies the fact to do the highlighting."
+Optional argument FACE specifies the face to do the highlighting."
   (overlay-put o 'original-face (overlay-get o 'face))
   (add-to-list 'pulse-momentary-overlay o)
   (if (eq pulse-flag 'never)
@@ -237,7 +237,7 @@
 
 (defun pulse-momentary-highlight-region (start end &optional face)
   "Highlight between START and END, unhighlighting before next command.
-Optional argument FACE specifies the fact to do the highlighting."
+Optional argument FACE specifies the face to do the highlighting."
   (let ((o (make-overlay start end)))
     ;; Mark it for deletion
     (overlay-put o 'pulse-delete t)

=== modified file 'lisp/cedet/semantic/idle.el'
--- a/lisp/cedet/semantic/idle.el       2013-06-19 20:29:09 +0000
+++ b/lisp/cedet/semantic/idle.el       2013-10-31 01:50:24 +0000
@@ -830,8 +830,14 @@
 ;; of all uses of the symbol that is under the cursor.
 ;;
 ;; This is to mimic the Eclipse tool of a similar nature.
-(defvar semantic-idle-symbol-highlight-face 'region
+(defface semantic-idle-symbol-highlight
+  '((t :inherit region))
+  "Face used for highlighting local symbols."
+  :group 'semantic-faces)
+(defvar semantic-idle-symbol-highlight-face 'semantic-idle-symbol-highlight
   "Face used for highlighting local symbols.")
+(make-obsolete-variable 'semantic-idle-symbol-highlight-face
+    "customize the face `semantic-idle-symbol-highlight' instead" "24.4" 'set)
 
 (defun semantic-idle-symbol-maybe-highlight (tag)
   "Perhaps add highlighting to the symbol represented by TAG.