[Emacs-diffs] trunk r116972: * lisp/emacs-lisp/cl-lib.el (current-case-table): Remove setter.

[Stefan Monnier]

------------------------------------------------------------
revno: 116972
revision-id: address@hidden
parent: address@hidden
committer: Stefan Monnier <address@hidden>
branch nick: trunk
timestamp: Sat 2014-04-12 15:30:14 -0400
message:
  * lisp/emacs-lisp/cl-lib.el (current-case-table): Remove setter.
  * lisp/leim/quail/sisheng.el (sisheng-list): Use with-case-table.
modified:
  lisp/ChangeLog                 changelog-20091113204419-o5vbwnq5f7feedwu-1432
  lisp/emacs-lisp/cl-lib.el      cl.el-20091113204419-o5vbwnq5f7feedwu-614
  lisp/leim/quail/sisheng.el     sisheng.el-20091113204419-o5vbwnq5f7feedwu-3061
  lisp/mail/smtpmail.el          smtpmail.el-20091113204419-o5vbwnq5f7feedwu-983

=== modified file 'lisp/ChangeLog'
--- a/lisp/ChangeLog    2014-04-12 19:24:17 +0000
+++ b/lisp/ChangeLog    2014-04-12 19:30:14 +0000
@@ -1,3 +1,8 @@
+2014-04-12  Stefan Monnier  <address@hidden>
+
+       * emacs-lisp/cl-lib.el (current-case-table): Remove setter.
+       * leim/quail/sisheng.el (sisheng-list): Use with-case-table.
+
 2014-04-12  Eli Zaretskii  <address@hidden>
 
        * international/characters.el <standard-case-table>: Add entries

=== modified file 'lisp/emacs-lisp/cl-lib.el'
--- a/lisp/emacs-lisp/cl-lib.el 2014-01-01 07:43:34 +0000
+++ b/lisp/emacs-lisp/cl-lib.el 2014-04-12 19:30:14 +0000
@@ -625,7 +625,6 @@
   `(insert (prog1 ,store (erase-buffer))))
 (gv-define-simple-setter buffer-substring cl--set-buffer-substring)
 (gv-define-simple-setter current-buffer set-buffer)
-(gv-define-simple-setter current-case-table set-case-table)
 (gv-define-simple-setter current-column move-to-column t)
 (gv-define-simple-setter current-global-map use-global-map t)
 (gv-define-setter current-input-mode (store)

=== modified file 'lisp/leim/quail/sisheng.el'
--- a/lisp/leim/quail/sisheng.el        2014-01-01 07:43:34 +0000
+++ b/lisp/leim/quail/sisheng.el        2014-04-12 19:30:14 +0000
@@ -249,42 +249,40 @@
 
 ;; Call quail-make-sisheng-rules for all syllables in sisheng-syllable-table.
 ;;
-(let ((case-table-save (current-case-table))
-      sisheng-list)
-  (set-case-table (standard-case-table))
-  (dolist (syllable sisheng-syllable-table)
-    (setq sisheng-list
-         (append (quail-make-sisheng-rules syllable)
-                 sisheng-list)))
-
-  (dolist (syllable sisheng-syllable-table)
-    (setq sisheng-list
-         (append (quail-make-sisheng-rules (upcase-initials syllable))
-                 sisheng-list)))
-
-  (dolist (syllable sisheng-syllable-table)
-    (setq sisheng-list
-         (append (quail-make-sisheng-rules (upcase syllable))
-                 sisheng-list)))
-
-  (eval `(quail-define-rules
-         ,@sisheng-list
-
-         ("lv5" ["lü"])
-         ("lve5" ["lüe"])
-         ("nv5" ["nü"])
-         ("nve5" ["nüe"])
-
-         ("Lv5" ["Lü"])
-         ("Lve5" ["Lüe"])
-         ("Nv5" ["Nü"])
-         ("Nve5" ["Nüe"])
-
-         ("LV5" ["LÜ"])
-         ("LVE5" ["LÜE"])
-         ("NV5" ["NÜ"])
-         ("NVE5" ["NÜE"])))
-  (set-case-table case-table-save))
+(let (sisheng-list)
+  (with-case-table (standard-case-table) ;FIXME: Why?
+    (dolist (syllable sisheng-syllable-table)
+      (setq sisheng-list
+            (append (quail-make-sisheng-rules syllable)
+                    sisheng-list)))
+
+    (dolist (syllable sisheng-syllable-table)
+      (setq sisheng-list
+            (append (quail-make-sisheng-rules (upcase-initials syllable))
+                    sisheng-list)))
+
+    (dolist (syllable sisheng-syllable-table)
+      (setq sisheng-list
+            (append (quail-make-sisheng-rules (upcase syllable))
+                    sisheng-list)))
+
+    (eval `(quail-define-rules
+            ,@sisheng-list
+
+            ("lv5" ["lü"])
+            ("lve5" ["lüe"])
+            ("nv5" ["nü"])
+            ("nve5" ["nüe"])
+
+            ("Lv5" ["Lü"])
+            ("Lve5" ["Lüe"])
+            ("Nv5" ["Nü"])
+            ("Nve5" ["Nüe"])
+
+            ("LV5" ["LÜ"])
+            ("LVE5" ["LÜE"])
+            ("NV5" ["NÜ"])
+            ("NVE5" ["NÜE"])))))
 
 ;; Local Variables:
 ;; coding: utf-8

=== modified file 'lisp/mail/smtpmail.el'
--- a/lisp/mail/smtpmail.el     2014-01-01 07:43:34 +0000
+++ b/lisp/mail/smtpmail.el     2014-04-12 19:30:14 +0000
@@ -733,7 +733,7 @@
                                (plist-get (cdr result) :capabilities)
                                "\r\n")))
                  (let ((name
-                        (with-case-table ascii-case-table
+                        (with-case-table ascii-case-table ;FIXME: Why?
                           (mapcar (lambda (s) (intern (downcase s)))
                                   (split-string (substring line 4) "[ ]")))))
                    (when (= (length name) 1)