emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] emacs-25 6475f92: Port "$@" to OpenIndiana ksh93


From: Paul Eggert
Subject: [Emacs-diffs] emacs-25 6475f92: Port "$@" to OpenIndiana ksh93
Date: Mon, 25 Jan 2016 01:29:05 +0000

branch: emacs-25
commit 6475f9265ecf21a8d49bc3ac0dc66010c9ec6b05
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>

    Port "$@" to OpenIndiana ksh93
    
    In http://lists.gnu.org/archive/html/bug-autoconf/2015-12/msg00000.html
    Pavel Raiskup reports that ${1+"$@"} runs afoul of a bug in /bin/sh
    (derived from ksh 93t+ 2010-03-05).  ${1+"$@"} works around an ancient
    bug in long-dead shells, so remove the workaround.
    * admin/check-doc-strings, configure.ac, lib-src/rcs2log:
    Use plain "$@" rather than ${1+"$@"}.
---
 admin/check-doc-strings |    3 +--
 configure.ac            |    2 +-
 lib-src/rcs2log         |    4 ++--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/admin/check-doc-strings b/admin/check-doc-strings
index 13e8b0c..63856d3 100755
--- a/admin/check-doc-strings
+++ b/admin/check-doc-strings
@@ -1,5 +1,5 @@
 : #-*- Perl -*-
-eval 'exec perl -S $0 ${1+"$@"}' # Portability kludge
+eval 'exec perl -S $0 "$@"' # Portability kludge
     if 0;
 
 # Author: Martin Buchholz
@@ -299,4 +299,3 @@ foreach my $fun (sort keys %texi_funtype) {
     print "nuke-this-doc: $fun $texi_funtype{$fun}\n";
   }
 }
-
diff --git a/configure.ac b/configure.ac
index 76193fa..7a3d4d9 100644
--- a/configure.ac
+++ b/configure.ac
@@ -33,7 +33,7 @@ emacs_config_options=
 optsep=
 dnl This is the documented way to record the args passed to configure,
 dnl rather than $ac_configure_args.
-for opt in ${1+"$@"} CFLAGS CPPFLAGS LDFLAGS; do
+for opt in "$@" CFLAGS CPPFLAGS LDFLAGS; do
   case $opt in
     -n | --no-create | --no-recursion)
       continue ;;
diff --git a/lib-src/rcs2log b/lib-src/rcs2log
index 73213c5..ff4d470 100755
--- a/lib-src/rcs2log
+++ b/lib-src/rcs2log
@@ -403,8 +403,8 @@ case $rlogfile in
        esac
 
        case $datearg in
-       ?*) $rlog $rlog_options "$datearg" ${1+"$@"} >$rlogfile;;
-       '') $rlog $rlog_options ${1+"$@"} >$rlogfile;;
+       ?*) $rlog $rlog_options "$datearg" "$@" >$rlogfile;;
+       '') $rlog $rlog_options "$@" >$rlogfile;;
        esac || exit;;
 esac
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]