emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master ee3daab: ibuffer-do-toggle-read-only: Fix unused ar


From: Tino Calancha
Subject: [Emacs-diffs] master ee3daab: ibuffer-do-toggle-read-only: Fix unused argument
Date: Sat, 17 Sep 2016 13:41:08 +0000 (UTC)

branch: master
commit ee3daab0232189d51eef46e793aea087c271688c
Author: Tino Calancha <address@hidden>
Commit: Tino Calancha <address@hidden>

    ibuffer-do-toggle-read-only: Fix unused argument
    
    * lisp/ibuffer.el (ibuffer-do-toggle-read-only): Call
    'read-only-mode' with ARG when its an integer.
    Clarify the meaning of ARG in doc string.
---
 lisp/ibuffer.el |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index 8e24629..0336f1d 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -1299,13 +1299,15 @@ a new window in the current frame, splitting 
vertically."
    :modifier-p t)
   (set-buffer-modified-p (not (buffer-modified-p))))
 
-(define-ibuffer-op ibuffer-do-toggle-read-only (&optional _arg);FIXME:arg 
unused!
+(define-ibuffer-op ibuffer-do-toggle-read-only (&optional arg)
   "Toggle read only status in marked buffers.
-With optional ARG, make read-only only if ARG is not negative."
+If optional ARG is a non-negative integer, make buffers read only.
+If ARG is a negative integer or 0, make buffers writable.
+Otherwise, toggle read only status."
   (:opstring "toggled read only status in"
    :interactive "P"
    :modifier-p t)
-  (read-only-mode 'toggle))
+  (read-only-mode (if (integerp arg) arg 'toggle)))
 
 (define-ibuffer-op ibuffer-do-delete ()
   "Kill marked buffers as with `kill-this-buffer'."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]