emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 6c995e4: Fix a mis-binding and a bad defun name in


From: Reuben Thomas
Subject: [Emacs-diffs] master 6c995e4: Fix a mis-binding and a bad defun name in a test (Bug#28319)
Date: Fri, 1 Sep 2017 18:41:22 -0400 (EDT)

branch: master
commit 6c995e4194d016fa8959acffd5787da4d3032f05
Author: Reuben Thomas <address@hidden>
Commit: Reuben Thomas <address@hidden>

    Fix a mis-binding and a bad defun name in a test (Bug#28319)
    
    test/lib-src/emacs-client-tests.el (call-emacsclient): Rename
    emacsclient-test-call-emacsclient.
    (emacsclient-test-alternate-editor-allows-arguments)
    (emacsclient-test-alternate-editor-allows-quotes): Fix let-binding of
    process-environment.
    
    Thanks to Glenn Morris for noticing these errors.
---
 test/lib-src/emacsclient-tests.el | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/lib-src/emacsclient-tests.el 
b/test/lib-src/emacsclient-tests.el
index e454e28..91f1f10 100644
--- a/test/lib-src/emacsclient-tests.el
+++ b/test/lib-src/emacsclient-tests.el
@@ -31,26 +31,26 @@
                                    "lib-src"))
   "Path to emacsclient binary in build tree.")
 
-(defun call-emacsclient ()
+(defun emacsclient-test-call-emacsclient ()
   "Run emacsclient."
   (call-process emacsclient-test-emacs nil nil nil
                 "--server-file" (expand-file-name "non-existent-file" 
invocation-directory)
                 "foo"))
 
 (ert-deftest emacsclient-test-alternate-editor-allows-arguments ()
-  (let (process-environment process-environment)
+  (let ((process-environment process-environment))
     (setenv "ALTERNATE_EDITOR" (concat
                                 (expand-file-name invocation-name 
invocation-directory)
                                 " --batch"))
-    (should (= 0 (call-emacsclient)))))
+    (should (= 0 (emacsclient-test-call-emacsclient)))))
 
 (ert-deftest emacsclient-test-alternate-editor-allows-quotes ()
-  (let (process-environment process-environment)
+  (let ((process-environment process-environment))
     (setenv "ALTERNATE_EDITOR" (concat
                                 "\""
                                 (expand-file-name invocation-name 
invocation-directory)
                                 "\"" " --batch"))
-    (should (= 0 (call-emacsclient)))))
+    (should (= 0 (emacsclient-test-call-emacsclient)))))
 
 (provide 'emacsclient-tests)
 ;;; emacsclient-tests.el ends here



reply via email to

[Prev in Thread] Current Thread [Next in Thread]