[Emacs-diffs] scratch/flymake-refactor-cleaner-for-emacs-26 da45044 09/39: Flymake's flymake-proc.el parses column numbers from gcc/javac errors

[João Távora]

branch: scratch/flymake-refactor-cleaner-for-emacs-26
commit da450444ed0584dbda3185485f0b3d3502720d6b
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>

    Flymake's flymake-proc.el parses column numbers from gcc/javac errors
    
    Column numbers are not a great way of marking diagnostic regions, but
    that's probably all that can be expected from the flymake-proc.el
    backend.  For now, try (end-of-thing 'sexp) to discover the
    diagnostic's end position.
    
    * lisp/progmodes/flymake-proc.el ()
    (flymake-proc-err-line-patterns): Also parse column numbers,
    if available, for gcc/javac warnings.
---
 lisp/progmodes/flymake-proc.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/flymake-proc.el b/lisp/progmodes/flymake-proc.el
index abda259..dd6bf50 100644
--- a/lisp/progmodes/flymake-proc.el
+++ b/lisp/progmodes/flymake-proc.el
@@ -558,8 +558,8 @@ Convert it to flymake internal format."
      ("\\(?:Parse\\|Fatal\\) error: \\(.*\\) in \\(.*\\) on line \\([0-9]+\\)" 
2 3 nil 1)
      ;; LaTeX warnings (fileless) ("\\(LaTeX \\(Warning\\|Error\\): .*\\) on 
input line \\([0-9]+\\)" 20 3 nil 1)
      ;; ant/javac.  Note this also matches gcc warnings!
-     (" *\\(\\[javac\\] 
*\\)?\\(\\([a-zA-Z]:\\)?[^:(\t\n]+\\):\\([0-9]+\\)\\(?::[0-9]+\\)?:[ 
\t\n]*\\(.+\\)"
-      2 4 nil 5))
+     (" *\\(\\[javac\\] 
*\\)?\\(\\([a-zA-Z]:\\)?[^:(\t\n]+\\):\\([0-9]+\\)\\(?::\\([0-9]+\\)\\)?:[ 
\t\n]*\\(.+\\)"
+      2 4 5 6))
    ;; compilation-error-regexp-alist)
    (flymake-proc-reformat-err-line-patterns-from-compile-el 
compilation-error-regexp-alist-alist))
   "Patterns for matching error/warning lines.  Each pattern has the form