emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] emacs-26 d815de0: Skip a Flymake test for old gcc versions


From: João Távora
Subject: [Emacs-diffs] emacs-26 d815de0: Skip a Flymake test for old gcc versions
Date: Fri, 20 Oct 2017 06:30:24 -0400 (EDT)

branch: emacs-26
commit d815de017bb531fed751ee0515ed90b73d7a9936
Author: João Távora <address@hidden>
Commit: João Távora <address@hidden>

    Skip a Flymake test for old gcc versions
    
    Fixes: 28906
    
    * test/lisp/progmodes/flymake-tests.el
    (different-diagnostic-types): Skip this test for gcc versions
    < 5.
---
 test/lisp/progmodes/flymake-tests.el | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/test/lisp/progmodes/flymake-tests.el 
b/test/lisp/progmodes/flymake-tests.el
index 9f570ad..eddd964 100644
--- a/test/lisp/progmodes/flymake-tests.el
+++ b/test/lisp/progmodes/flymake-tests.el
@@ -24,6 +24,7 @@
 ;;; Code:
 (require 'ert)
 (require 'flymake)
+(require 'subr-x) ; string-trim
 
 (defvar flymake-tests-data-directory
   (expand-file-name "lisp/progmodes/flymake-resources"
@@ -128,7 +129,11 @@ SEVERITY-PREDICATE is used to setup
 
 (ert-deftest different-diagnostic-types ()
   "Test GCC warning via function predicate."
-  (skip-unless (and (executable-find "gcc") (executable-find "make")))
+  (skip-unless (and (executable-find "gcc")
+                    (version<=
+                     "5" (string-trim
+                          (shell-command-to-string "gcc -dumpversion")))
+                    (executable-find "make")))
   (let ((flymake-wrap-around nil))
     (flymake-tests--with-flymake
         ("errors-and-warnings.c")



reply via email to

[Prev in Thread] Current Thread [Next in Thread]