[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master a92e7b4: Don’t set print-escape-newlines in the mi

From: Paul Eggert
Subject: [Emacs-diffs] master a92e7b4: Don’t set print-escape-newlines in the minibuffer
Date: Wed, 25 Apr 2018 15:26:04 -0400 (EDT)

branch: master
commit a92e7b4ef6915e079a97e4e33e45b11508170cb1
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>

    Don’t set print-escape-newlines in the minibuffer
    This appears to be an unnecessary and possibly-confusing
    revenant from ancient code (Bug#31251).  See thread containing:
    * src/minibuf.c (read_minibuf): Do not set print-escape-newlines.
    * src/print.c (syms_of_print): Do not defsym print-escape-newlines
    or print-escape-control-characters, as these symbols are not used
    in C code.
 src/minibuf.c | 7 -------
 src/print.c   | 2 --
 2 files changed, 9 deletions(-)

diff --git a/src/minibuf.c b/src/minibuf.c
index 11b3fe2..c41958d 100644
--- a/src/minibuf.c
+++ b/src/minibuf.c
@@ -595,13 +595,6 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, 
Lisp_Object prompt,
   XWINDOW (minibuf_window)->hscroll = 0;
   XWINDOW (minibuf_window)->suspend_auto_hscroll = 0;
-  /* Why does this code set print-escape-newlines?  No call to Fprin1
-     or to Fprint is anywhere in sight.  FIXME: Either remove the next
-     two lines of code along with this comment, or replace this
-     comment with an explanation for why the two lines are needed.  */
-  Fmake_local_variable (Qprint_escape_newlines);
-  print_escape_newlines = 1;
   /* Erase the buffer.  */
     ptrdiff_t count1 = SPECPDL_INDEX ();
diff --git a/src/print.c b/src/print.c
index a8bbb9d..7c6856a 100644
--- a/src/print.c
+++ b/src/print.c
@@ -2447,10 +2447,8 @@ priorities.  */);
   defsubr (&Sredirect_debugging_output);
   defsubr (&Sprint_preprocess);
-  DEFSYM (Qprint_escape_newlines, "print-escape-newlines");
   DEFSYM (Qprint_escape_multibyte, "print-escape-multibyte");
   DEFSYM (Qprint_escape_nonascii, "print-escape-nonascii");
-  DEFSYM (Qprint_escape_control_characters, "print-escape-control-characters");
   print_prune_charset_plist = Qnil;
   staticpro (&print_prune_charset_plist);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]