emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 6d6f45e: Fix off-by-1 typo in recent bignum changes


From: Paul Eggert
Subject: [Emacs-diffs] master 6d6f45e: Fix off-by-1 typo in recent bignum changes
Date: Thu, 30 Aug 2018 17:28:47 -0400 (EDT)

branch: master
commit 6d6f45e21830a57b4a12af0f89913752a137a653
Author: Paul Eggert <address@hidden>
Commit: Paul Eggert <address@hidden>

    Fix off-by-1 typo in recent bignum changes
    
    Problem reported by Yuri D’Elia in:
    https://lists.gnu.org/r/emacs-devel/2018-08/msg00977.html
    and crucial clue provided by Michael Heerdegen in:
    https://lists.gnu.org/r/emacs-devel/2018-08/msg01043.html
    * src/font.c (font_unparse_xlfd): Fix off-by-1 typo.
---
 src/font.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/font.c b/src/font.c
index 4a63700..e241458 100644
--- a/src/font.c
+++ b/src/font.c
@@ -1290,7 +1290,7 @@ font_unparse_xlfd (Lisp_Object font, int pixel_size, char 
*name, int nbytes)
   if (INTEGERP (val))
     {
       intmax_t v = FIXNUMP (val) ? XFIXNUM (val) : bignum_to_intmax (val);
-      if (! (0 <= v && v <= TYPE_MAXIMUM (uprintmax_t)))
+      if (! (0 < v && v <= TYPE_MAXIMUM (uprintmax_t)))
        v = pixel_size;
       if (v > 0)
        {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]