emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master ef183b9: * src/data.c (Ffset): Don't signal gratuit


From: Stefan Monnier
Subject: [Emacs-diffs] master ef183b9: * src/data.c (Ffset): Don't signal gratuitous errors
Date: Fri, 2 Nov 2018 15:00:40 -0400 (EDT)

branch: master
commit ef183b996c3aade55e16d8fbcd68d9c4f360729e
Author: Stefan Monnier <address@hidden>
Commit: Stefan Monnier <address@hidden>

    * src/data.c (Ffset): Don't signal gratuitous errors
---
 src/data.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/data.c b/src/data.c
index 538081e..f8b991e 100644
--- a/src/data.c
+++ b/src/data.c
@@ -758,7 +758,9 @@ DEFUN ("fset", Ffset, Sfset, 2, 2, 0,
   register Lisp_Object function;
   CHECK_SYMBOL (symbol);
   /* Perhaps not quite the right error signal, but seems good enough.  */
-  if (NILP (symbol))
+  if (NILP (symbol) && !NILP (definition))
+    /* There are so many other ways to shoot oneself in the foot, I don't
+       think this one little sanity check is worth its cost, but anyway.  */
     xsignal1 (Qsetting_constant, symbol);
 
   function = XSYMBOL (symbol)->u.s.function;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]