[Emacs-diffs] feature/gnus-select 280de6e 061/218: Make compiler warn about use of obsolete hooks

[Andrew G Cohen]

branch: feature/gnus-select
commit 280de6e628300196a533c018e69dae740bf2f8f6
Author: Glenn Morris <address@hidden>
Commit: Andrew G Cohen <address@hidden>

    Make compiler warn about use of obsolete hooks
    
    * lisp/emacs-lisp/bytecomp.el (byte-compile-form):
    Warn about using obsolete hooks.
---
 lisp/emacs-lisp/bytecomp.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 2a986f6..b3ea930 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -3119,6 +3119,11 @@ for symbols generated by the byte compiler itself."
              (when (assq var byte-compile-lexical-variables)
                (byte-compile-report-error
                 (format-message "%s cannot use lexical var `%s'" fn var))))))
+        ;; Warn about using obsolete hooks.
+        (if (memq fn '(add-hook remove-hook))
+            (let ((hook (car-safe (cdr form))))
+              (if (eq (car-safe hook) 'quote)
+                  (byte-compile-check-variable (cadr hook) nil))))
         (when (and (byte-compile-warning-enabled-p 'suspicious)
                    (macroexp--const-symbol-p fn))
           (byte-compile-warn "`%s' called as a function" fn))