emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master d96b672: Use lexical-binding in bug-reference.el


From: Alex Branham
Subject: [Emacs-diffs] master d96b672: Use lexical-binding in bug-reference.el
Date: Tue, 9 Apr 2019 17:30:36 -0400 (EDT)

branch: master
commit d96b672f2b738bb6364023c2dcb9111efd3855ed
Author: Alex Branham <address@hidden>
Commit: Alex Branham <address@hidden>

    Use lexical-binding in bug-reference.el
    
    * .dir-locals.el: Set bug-reference-url-format in all modes, not just
    changelog mode. Use (eval . (bug-reference-mode)) as described
    in (info "(emacs) Specifying File Variables")
    * lisp/progmodes/bug-reference.el: Use lexical binding.
    (bug-reference-unfontify):
    (bug-reference-fontify): Mention args in docstring.
    
    Bug#35123
---
 .dir-locals.el                  | 6 +++---
 lisp/progmodes/bug-reference.el | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.dir-locals.el b/.dir-locals.el
index 9cd3992..ffd65c8 100644
--- a/.dir-locals.el
+++ b/.dir-locals.el
@@ -1,6 +1,7 @@
 ((nil . ((tab-width . 8)
          (sentence-end-double-space . t)
-         (fill-column . 70)))
+         (fill-column . 70)
+         (bug-reference-url-format . "https://debbugs.gnu.org/%s";)))
  (c-mode . ((c-file-style . "GNU")
             (c-noise-macro-names . ("INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" 
"UNINIT" "CALLBACK" "ALIGN_STACK"))
             (electric-quote-comment . nil)
@@ -12,8 +13,7 @@
                    (log-edit-setup-add-author . t)))
  (change-log-mode . ((add-log-time-zone-rule . t)
                     (fill-column . 74)
-                    (bug-reference-url-format . "https://debbugs.gnu.org/%s";)
-                    (mode . bug-reference)))
+                    (eval . (bug-reference-mode))))
  (diff-mode . ((mode . whitespace)))
  (emacs-lisp-mode . ((indent-tabs-mode . nil)
                      (electric-quote-comment . nil)
diff --git a/lisp/progmodes/bug-reference.el b/lisp/progmodes/bug-reference.el
index 759db1f..813ecbe 100644
--- a/lisp/progmodes/bug-reference.el
+++ b/lisp/progmodes/bug-reference.el
@@ -1,4 +1,4 @@
-;; bug-reference.el --- buttonize bug references
+;; bug-reference.el --- buttonize bug references  -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2008-2019 Free Software Foundation, Inc.
 
@@ -91,7 +91,7 @@ The second subexpression should match the bug reference 
(usually a number)."
 (bug-reference-set-overlay-properties)
 
 (defun bug-reference-unfontify (start end)
-  "Remove bug reference overlays from region."
+  "Remove bug reference overlays from the region between START and END."
   (dolist (o (overlays-in start end))
     (when (eq (overlay-get o 'category) 'bug-reference)
       (delete-overlay o))))
@@ -99,7 +99,7 @@ The second subexpression should match the bug reference 
(usually a number)."
 (defvar bug-reference-prog-mode)
 
 (defun bug-reference-fontify (start end)
-  "Apply bug reference overlays to region."
+  "Apply bug reference overlays to the region between START and END."
   (save-excursion
     (let ((beg-line (progn (goto-char start) (line-beginning-position)))
          (end-line (progn (goto-char end) (line-end-position))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]