[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Emacs-diffs] scratch/with-suppressed-warnings 2a15eda 2/2: Enable suppr
From: |
Lars Ingebrigtsen |
Subject: |
[Emacs-diffs] scratch/with-suppressed-warnings 2a15eda 2/2: Enable suppression of more warnings |
Date: |
Sun, 9 Jun 2019 11:45:23 -0400 (EDT) |
branch: scratch/with-suppressed-warnings
commit 2a15edaa4702ae35967873333c85eedb6307e3ef
Author: Lars Ingebrigtsen <address@hidden>
Commit: Lars Ingebrigtsen <address@hidden>
Enable suppression of more warnings
---
lisp/emacs-lisp/bytecomp.el | 22 ++++++++++++----------
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index f9f9e6a..fa2cd1a 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -2588,7 +2588,7 @@ not to take responsibility for the actual compilation of
the code."
(setq byte-compile-call-tree
(cons (list name nil nil) byte-compile-call-tree))))
- (if (byte-compile-warning-enabled-p 'redefine)
+ (if (byte-compile-warning-enabled-p 'redefine name)
(byte-compile-arglist-warn name arglist macro))
(if byte-compile-verbose
@@ -2600,7 +2600,7 @@ not to take responsibility for the actual compilation of
the code."
;; This also silences "multiple definition" warnings for defmethods.
nil)
(that-one
- (if (and (byte-compile-warning-enabled-p 'redefine)
+ (if (and (byte-compile-warning-enabled-p 'redefine name)
;; Don't warn when compiling the stubs in byte-run...
(not (assq name byte-compile-initial-macro-environment)))
(byte-compile-warn
@@ -2608,7 +2608,7 @@ not to take responsibility for the actual compilation of
the code."
name))
(setcdr that-one nil))
(this-one
- (when (and (byte-compile-warning-enabled-p 'redefine)
+ (when (and (byte-compile-warning-enabled-p 'redefine name)
;; Hack: Don't warn when compiling the magic internal
;; byte-compiler macros in byte-run.el...
(not (assq name byte-compile-initial-macro-environment)))
@@ -2617,7 +2617,7 @@ not to take responsibility for the actual compilation of
the code."
name)))
((eq (car-safe (symbol-function name))
(if macro 'lambda 'macro))
- (when (byte-compile-warning-enabled-p 'redefine)
+ (when (byte-compile-warning-enabled-p 'redefine name)
(byte-compile-warn "%s `%s' being redefined as a %s"
(if macro "function" "macro")
name
@@ -3233,7 +3233,7 @@ for symbols generated by the byte compiler itself."
(if byte-compile-generate-call-tree
(byte-compile-annotate-call-tree form))
(when (and byte-compile--for-effect (eq (car form) 'mapcar)
- (byte-compile-warning-enabled-p 'mapcar))
+ (byte-compile-warning-enabled-p 'mapcar 'mapcar))
(byte-compile-set-symbol-position 'mapcar)
(byte-compile-warn
"`mapcar' called for effect; use `mapc' or `dolist' instead"))
@@ -3369,7 +3369,8 @@ for symbols generated by the byte compiler itself."
(when (symbolp var)
(byte-compile-set-symbol-position var))
(cond ((or (not (symbolp var)) (macroexp--const-symbol-p var))
- (when (byte-compile-warning-enabled-p 'constants)
+ (when (byte-compile-warning-enabled-p 'constants
+ (and (symbolp var) var))
(byte-compile-warn (if (eq access-type 'let-bind)
"attempt to let-bind %s `%s'"
"variable reference to %s `%s'")
@@ -3422,7 +3423,7 @@ for symbols generated by the byte compiler itself."
;; VAR is lexically bound.
(byte-compile-stack-set (cdr lex-binding))
;; VAR is dynamically bound.
- (unless (or (not (byte-compile-warning-enabled-p 'free-vars))
+ (unless (or (not (byte-compile-warning-enabled-p 'free-vars var))
(boundp var)
(memq var byte-compile-bound-variables)
(memq var byte-compile-free-assignments))
@@ -3907,7 +3908,7 @@ discarding."
(defun byte-compile-function-form (form)
(let ((f (nth 1 form)))
(when (and (symbolp f)
- (byte-compile-warning-enabled-p 'callargs))
+ (byte-compile-warning-enabled-p 'callargs f))
(byte-compile-function-warn f t (byte-compile-fdefinition f nil)))
(byte-compile-constant (if (eq 'lambda (car-safe f))
@@ -3977,7 +3978,8 @@ discarding."
(let ((var (car-safe (cdr varexp))))
(and (or (not (symbolp var))
(macroexp--const-symbol-p var t))
- (byte-compile-warning-enabled-p 'constants)
+ (byte-compile-warning-enabled-p 'constants
+ (and (symbolp var) var))
(byte-compile-warn
"variable assignment to %s `%s'"
(if (symbolp var) "constant" "nonvariable")
@@ -4638,7 +4640,7 @@ binding slots have been popped."
(defun byte-compile-save-excursion (form)
(if (and (eq 'set-buffer (car-safe (car-safe (cdr form))))
- (byte-compile-warning-enabled-p 'suspicious))
+ (byte-compile-warning-enabled-p 'suspicious 'set-buffer))
(byte-compile-warn
"Use `with-current-buffer' rather than save-excursion+set-buffer"))
(byte-compile-out 'byte-save-excursion 0)