emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master a6191e0: Remove outdated FIXME


From: Lars Ingebrigtsen
Subject: [Emacs-diffs] master a6191e0: Remove outdated FIXME
Date: Thu, 13 Jun 2019 11:19:39 -0400 (EDT)

branch: master
commit a6191e060ba5bb2988340bcc44018d4cb0877733
Author: Lars Ingebrigtsen <address@hidden>
Commit: Lars Ingebrigtsen <address@hidden>

    Remove outdated FIXME
    
    * lisp/emacs-lisp/eieio-core.el (eieio--slot-name-index): Remove
    comment about issuing a byte compilation warning about accessing
    slots via :initarg -- it was implemented a few months later.
---
 lisp/emacs-lisp/eieio-core.el | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lisp/emacs-lisp/eieio-core.el b/lisp/emacs-lisp/eieio-core.el
index 30445f9..01a821e 100644
--- a/lisp/emacs-lisp/eieio-core.el
+++ b/lisp/emacs-lisp/eieio-core.el
@@ -866,7 +866,6 @@ reverse-lookup that name, and recurse with the associated 
slot value."
        (if fn
             ;; Accessing a slot via its :initarg is accepted by EIEIO
             ;; (but not CLOS) but is a bad idea (for one: it's slower).
-            ;; FIXME: We should emit a compile-time warning when this happens!
             (eieio--slot-name-index class fn)
           nil)))))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]