emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Emacs-diffs] master 2396aea 2/2: Fix compilation warning in esh-mode


From: Lars Ingebrigtsen
Subject: [Emacs-diffs] master 2396aea 2/2: Fix compilation warning in esh-mode
Date: Thu, 20 Jun 2019 08:06:05 -0400 (EDT)

branch: master
commit 2396aea6fdd3fbcb5c54880db3ce09122742f6c2
Author: Lars Ingebrigtsen <address@hidden>
Commit: Lars Ingebrigtsen <address@hidden>

    Fix compilation warning in esh-mode
    
    * lisp/eshell/esh-mode.el (eshell-mode): Remove special binding
    for M-. in eshell buffers: The comment indicates that this is
    outdated code.
    (eshell-find-tag): Make obsolete.
---
 lisp/eshell/esh-mode.el | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
index 5644928..80844c3 100644
--- a/lisp/eshell/esh-mode.el
+++ b/lisp/eshell/esh-mode.el
@@ -326,10 +326,6 @@ and the hook `eshell-exit-hook'."
   (setq-local eshell-command-map (symbol-function eshell-command-prefix))
   (define-key eshell-mode-map [(control ?c)] eshell-command-prefix)
 
-  ;; without this, find-tag complains about read-only text being
-  ;; modified
-  (if (eq (key-binding [(meta ?.)]) 'find-tag)
-      (define-key eshell-mode-map [(meta ?.)] 'eshell-find-tag))
   (define-key eshell-command-map [(meta ?o)] 'eshell-mark-output)
   (define-key eshell-command-map [(meta ?d)] 'eshell-toggle-direct-send)
 
@@ -490,13 +486,15 @@ and the hook `eshell-exit-hook'."
 
 (defun eshell-find-tag (&optional tagname next-p regexp-p)
   "A special version of `find-tag' that ignores whether the text is read-only."
+  (declare (obsolete xref-find-definition "27.1"))
   (interactive)
   (require 'etags)
   (let ((inhibit-read-only t)
        (no-default (eobp))
        (find-tag-default-function 'ignore))
     (setq tagname (car (find-tag-interactive "Find tag: " no-default)))
-    (find-tag tagname next-p regexp-p)))
+    (with-suppressed-warnings ((obsolete find-tag))
+      (find-tag tagname next-p regexp-p))))
 
 (defun eshell-move-argument (limit func property arg)
   "Move forward ARG arguments."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]