[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 82a632e: 2020-03-29 Michael R. Mauger <address@hidden>

From: Michael Mauger
Subject: master 82a632e: 2020-03-29 Michael R. Mauger <address@hidden>
Date: Sat, 13 Jun 2020 18:42:54 -0400 (EDT)

branch: master
commit 82a632edc8b80bf16d9b9f205474bf9724b084c0
Author: Michael R. Mauger <michael@mauger.com>
Commit: Michael R. Mauger <michael@mauger.com>

    2020-03-29  Michael R. Mauger  <michael@mauger.com>
           * lisp/progmodes/sql.el (sql-add-product): Re-correct argument
           spec.  Previous change was due to my mistake; I have
           resolved back to the prior behavior (Bug#39960).
           * test/lisp/progmodes/sql-tests.el (sql-test-add-product): Added
           test to insure I don't make the same mistake again.
 lisp/progmodes/sql.el            | 2 +-
 test/lisp/progmodes/sql-tests.el | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el
index 6fd750d..c86fc59 100644
--- a/lisp/progmodes/sql.el
+++ b/lisp/progmodes/sql.el
@@ -2683,7 +2683,7 @@ highlighting rules in SQL mode.")
              nil 'require-match
              init 'sql-product-history init))))
-(defun sql-add-product (product display &optional plist)
+(defun sql-add-product (product display &rest plist)
   "Add support for a database product in `sql-mode'.
 Add PRODUCT to `sql-product-alist' which enables `sql-mode' to
diff --git a/test/lisp/progmodes/sql-tests.el b/test/lisp/progmodes/sql-tests.el
index 65ed76b..91805ab 100644
--- a/test/lisp/progmodes/sql-tests.el
+++ b/test/lisp/progmodes/sql-tests.el
@@ -187,7 +187,13 @@ Perform ACTION and validate results"
       (sql-add-product 'xyz "XyzDb")
       (should (equal (pp-to-string (assoc 'xyz sql-product-alist))
-                     "(xyz :name \"XyzDb\")\n"))))
+                     "(xyz :name \"XyzDb\")\n")))
+  (sql-test-product-feature-harness
+      (sql-add-product 'stu "StuDb" :X 1 :Y "2")
+      (should (equal (pp-to-string (assoc 'stu sql-product-alist))
+                     "(stu :name \"StuDb\" :X 1 :Y \"2\")\n"))))
 (ert-deftest sql-test-add-existing-product ()
   "Add a product that already exists."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]