emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master e8f5657: * lisp/emacs-lisp/lisp-mode.el: Avoid false-positive "hi


From: Stefan Monnier
Subject: master e8f5657: * lisp/emacs-lisp/lisp-mode.el: Avoid false-positive "hidden arg" in strings
Date: Sat, 7 Nov 2020 10:15:28 -0500 (EST)

branch: master
commit e8f5657bc7f6e0e45f70e4849736c6e87d44a1ac
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Commit: Stefan Monnier <monnier@iro.umontreal.ca>

    * lisp/emacs-lisp/lisp-mode.el: Avoid false-positive "hidden arg" in strings
    
    (lisp--match-hidden-arg): Don't misfire in strings and comments.
    
    Reported by: Andrii Kolomoiets <andreyk.mad@gmail.com>
---
 lisp/emacs-lisp/lisp-mode.el | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el
index 2689922..daf4967 100644
--- a/lisp/emacs-lisp/lisp-mode.el
+++ b/lisp/emacs-lisp/lisp-mode.el
@@ -178,13 +178,16 @@
 
 (defun lisp--match-hidden-arg (limit)
   (let ((res nil))
+    (forward-line 0)
     (while
-        (let ((ppss (parse-partial-sexp (line-beginning-position)
+        (let ((ppss (parse-partial-sexp (point)
                                         (line-end-position)
                                         -1)))
           (skip-syntax-forward " )")
           (if (or (>= (car ppss) 0)
-                  (looking-at ";\\|$"))
+                  (eolp)
+                  (looking-at ";")
+                  (nth 8 (syntax-ppss))) ;Within a string or comment.
               (progn
                 (forward-line 1)
                 (< (point) limit))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]