[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
feature/completions-highlight-modifications 8647012 06/18: Fix recursive
From: |
Jimmy Aguilar Mena |
Subject: |
feature/completions-highlight-modifications 8647012 06/18: Fix recursive set-keymap-parent in completions-highlight. |
Date: |
Wed, 18 Nov 2020 22:30:34 -0500 (EST) |
branch: feature/completions-highlight-modifications
commit 864701276458289acb999205c4d67e1324893838
Author: Jimmy Aguilar Mena <spacibba@aol.com>
Commit: Jimmy Aguilar Mena <spacibba@aol.com>
Fix recursive set-keymap-parent in completions-highlight.
*
lisp/completions-highlight.el (completions-highlight-minibuffer-bindings)
:
(completions-highlight-completions-bindings) : Condition
set-keymap-parent to avoid error.
---
lisp/completions-highlight.el | 17 ++++++++++-------
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/lisp/completions-highlight.el b/lisp/completions-highlight.el
index a16e4f9..00b7382 100644
--- a/lisp/completions-highlight.el
+++ b/lisp/completions-highlight.el
@@ -211,9 +211,12 @@ suffix."
When SET is nil the bindings are removed."
(if set
(let ((local-map (current-local-map)))
- (setq completions-highlight-minibuffer-map-save local-map)
- (set-keymap-parent completions-highlight-minibuffer-map local-map)
- (use-local-map completions-highlight-minibuffer-map))
+ (unless (eq local-map completions-highlight-minibuffer-map)
+ (setq completions-highlight-minibuffer-map-save local-map)
+ (unless (eq local-map
+ (keymap-parent completions-highlight-minibuffer-map))
+ (set-keymap-parent completions-highlight-minibuffer-map local-map))
+ (use-local-map completions-highlight-minibuffer-map)))
(use-local-map completions-highlight-minibuffer-map-save)))
@@ -222,11 +225,11 @@ When SET is nil the bindings are removed."
"Add extra keybindings to `completion-list-mode-map'.
When SET is nil the bindings are removed."
(if set
- (unless (keymap-parent completions-highlight-completions-map)
(let ((local-map (current-local-map)))
- (setq completions-highlight-completions-map-save local-map)
- (set-keymap-parent completions-highlight-completions-map local-map)
- (use-local-map completions-highlight-completions-map)))
+ (unless (eq local-map completions-highlight-completions-map)
+ (setq completions-highlight-completions-map-save local-map)
+ (set-keymap-parent completions-highlight-completions-map local-map)
+ (use-local-map completions-highlight-completions-map)))
;; Set is called already inside *Completions* but unset not
(when-let ((parent (keymap-parent completions-highlight-completions-map))
- branch feature/completions-highlight-modifications created (now ff46a8f), Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications c6a25d8 01/18: Insert some modifications to implement completions highlighting., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications f132cc3 02/18: Document the changes in the API for Completions., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications d812e76 05/18: Improve keymap handling., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 8647012 06/18: Fix recursive set-keymap-parent in completions-highlight.,
Jimmy Aguilar Mena <=
- feature/completions-highlight-modifications 8f3e475 03/18: Add completions-highlight-mode initial implementation., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications a6e73e8 04/18: Fix initial comment in completions-highlight file., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 8a60d7d 08/18: Simplify numeric argument, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications a686211 10/18: Simplify overlay handling, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 34570e1 14/18: Improve completions-highlight description in file header., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications bfe4747 12/18: Add parent maps, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 6db2c4a 17/18: Simplify and rely more in the post-command-hook, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications d397d2b 13/18: Add # to function bindings, Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications cb02cb6 11/18: Add autoload decorator., Jimmy Aguilar Mena, 2020/11/18
- feature/completions-highlight-modifications 9fe2441 15/18: Add custom variable completions-highlight-autoselect., Jimmy Aguilar Mena, 2020/11/18