emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master 2f00a34: Don't update `minor-modes' in global modes


From: Lars Ingebrigtsen
Subject: master 2f00a34: Don't update `minor-modes' in global modes
Date: Sun, 14 Feb 2021 10:51:23 -0500 (EST)

branch: master
commit 2f00a3435a05bbcedbf8851baeefd33463bc525b
Author: Lars Ingebrigtsen <larsi@gnus.org>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Don't update `minor-modes' in global modes
    
    * lisp/emacs-lisp/easy-mmode.el (define-minor-mode): There's no
    point in setting the buffer-local `minor-modes' in global modes.
---
 lisp/emacs-lisp/easy-mmode.el | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el
index 7e5e2a9..5ba0d21 100644
--- a/lisp/emacs-lisp/easy-mmode.el
+++ b/lisp/emacs-lisp/easy-mmode.el
@@ -330,10 +330,11 @@ or call the function `%s'."))))
                    nil)
                   (t
                    t)))
-           ;; Keep `minor-modes' up to date.
-           (setq minor-modes (delq ',modefun minor-modes))
-           (when ,getter
-             (push ',modefun minor-modes))
+           (unless ,globalp
+             ;; Keep `minor-modes' up to date.
+             (setq minor-modes (delq ',modefun minor-modes))
+             (when ,getter
+               (push ',modefun minor-modes)))
            ,@body
            ;; The on/off hooks are here for backward compatibility only.
            (run-hooks ',hook (if ,getter ',hook-on ',hook-off))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]