[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
scratch/so-long 99dd121 03/10: Increase `so-long-threshold' and `so-long
From: |
Phil Sainty |
Subject: |
scratch/so-long 99dd121 03/10: Increase `so-long-threshold' and `so-long-max-lines' defaults |
Date: |
Sat, 20 Mar 2021 23:25:14 -0400 (EDT) |
branch: scratch/so-long
commit 99dd12130e695c1e2444e6322c73cb8a2e3632f3
Author: Phil Sainty <psainty@orcon.net.nz>
Commit: Phil Sainty <psainty@orcon.net.nz>
Increase `so-long-threshold' and `so-long-max-lines' defaults
* lisp/so-long.el (so-long-threshold, so-long-max-lines): Increase
default values to reduce false-positives.
* etc/NEWS: Describe changes.
Lines shorter than 10,000 characters shouldn't generally be causing
problems, so testing this explicitly will largely eliminate
false-positives. We must also increase the maximum number of lines
to check, because 'minified' code may still include newlines, and so
there may be many lines shorter than the new threshold before we find
a line which exceeds it.
Previously we used a minimum-effort heuristic, testing a very small
number of lines against a maximum length which, while not remotely
long enough to cause problems, would nevertheless be uncommon in any
normal file of programming code (and hence indicative that the file
was likely to be minified code).
Testing indicates that the performance penalty for the larger values
should be negligible.
---
etc/NEWS | 7 +++++++
lisp/so-long.el | 11 ++++++-----
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/etc/NEWS b/etc/NEWS
index c602166..63bdbad 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -2232,6 +2232,13 @@ You can type 'C-x u u' instead of 'C-x u C-x u' to undo
many changes,
transient mode and then is executed normally. 'repeat-exit-key'
defines an additional key to exit mode like 'isearch-exit' ('RET').
+** So Long
+
+---
+*** 'so-long-threshold' and 'so-long-max-lines' have been raised to
+10000 characters and 500 lines respectively, to reduce the likelihood
+of false-positives when 'global-so-long-mode' is enabled.
+
* New Modes and Packages in Emacs 28.1
diff --git a/lisp/so-long.el b/lisp/so-long.el
index 9fdc356..a70b37a 100644
--- a/lisp/so-long.el
+++ b/lisp/so-long.el
@@ -391,7 +391,8 @@
;; * Change Log:
;;
-;; 1.1 - ?
+;; 1.1 - Increase `so-long-threshold' from 250 to 10,000.
+;; - Increase `so-long-max-lines' from 5 to 500.
;; 1.0 - Included in Emacs 27.1, and in GNU ELPA for prior versions of Emacs.
;; - New global mode `global-so-long-mode' to enable/disable the library.
;; - New user option `so-long-action'.
@@ -491,14 +492,14 @@
:prefix "so-long"
:group 'convenience)
-(defcustom so-long-threshold 250
+(defcustom so-long-threshold 10000
"Maximum line length permitted before invoking `so-long-function'.
See `so-long-detected-long-line-p' for details."
:type 'integer
- :package-version '(so-long . "1.0"))
+ :package-version '(so-long . "1.1"))
-(defcustom so-long-max-lines 5
+(defcustom so-long-max-lines 500
"Number of non-blank, non-comment lines to test for excessive length.
If nil then all lines will be tested, until either a long line is detected,
@@ -510,7 +511,7 @@ be counted.
See `so-long-detected-long-line-p' for details."
:type '(choice (integer :tag "Limit")
(const :tag "Unlimited" nil))
- :package-version '(so-long . "1.0"))
+ :package-version '(so-long . "1.1"))
(defcustom so-long-skip-leading-comments t
"Non-nil to ignore all leading comments and whitespace.
- branch scratch/so-long created (now ee03831), Phil Sainty, 2021/03/20
- scratch/so-long 5e414a4 01/10: ; * lisp/so-long.el: Documentation, Phil Sainty, 2021/03/20
- scratch/so-long 99dd121 03/10: Increase `so-long-threshold' and `so-long-max-lines' defaults,
Phil Sainty <=
- scratch/so-long 8b5667f 04/10: Make `global-so-long-mode' handle unrecognised file types, Phil Sainty, 2021/03/20
- scratch/so-long 723bf5d 06/10: ; * lisp/so-long.el: Minor bug fixes, Phil Sainty, 2021/03/20
- scratch/so-long 62e46bf 07/10: ; so-long-tests.el: Suppress expected warnings, Phil Sainty, 2021/03/20
- scratch/so-long 1ed2008 02/10: ; * lisp/so-long.el: Bump to version 1.1, Phil Sainty, 2021/03/20
- scratch/so-long a2f2790 05/10: * lisp/so-long.el (so-long-minor-modes): Add smartparens modes, Phil Sainty, 2021/03/20
- scratch/so-long ee03831 10/10: WIP: Update tests to cover usage of `buffer-line-statistics', Phil Sainty, 2021/03/20
- scratch/so-long 31843e5 09/10: WIP: Use `buffer-line-statistics', Phil Sainty, 2021/03/20
- scratch/so-long 6edeae3 08/10: Support 'preserved' variables and minor modes in `so-long-mode', Phil Sainty, 2021/03/20