emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master a28647a 3/3: Remove spurious %S from 'define-error' messages


From: Lars Ingebrigtsen
Subject: master a28647a 3/3: Remove spurious %S from 'define-error' messages
Date: Tue, 9 Nov 2021 19:17:32 -0500 (EST)

branch: master
commit a28647a6b6800212e632ea6b86763dbff4a40d00
Author: Tom Levy <tomlevy93@gmail.com>
Commit: Lars Ingebrigtsen <larsi@gnus.org>

    Remove spurious %S from 'define-error' messages
    
    ; The MESSAGE arg of 'define-error' does not support format specifiers
    ; (unlike the 'error' function). The signal data is automatically
    ; appended to the error message.
    
    * lisp/emacs/lisp/cl-generic.el (cl--generic-cyclic-definition):
    Remove spurious %S from error message.
    * lisp/emacs-lisp/gv.el (gv-invalid-place): Remove spurious %S from
    error message (and rephrase) (bug#51718).
    
    Copyright-paperwork-exempt: yes
---
 lisp/emacs-lisp/cl-generic.el | 2 +-
 lisp/emacs-lisp/gv.el         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/emacs-lisp/cl-generic.el b/lisp/emacs-lisp/cl-generic.el
index 3f75cf9..9de47e4 100644
--- a/lisp/emacs-lisp/cl-generic.el
+++ b/lisp/emacs-lisp/cl-generic.el
@@ -687,7 +687,7 @@ This is particularly useful when many different tags select 
the same set
 of methods, since this table then allows us to share a single combined-method
 for all those different tags in the method-cache.")
 
-(define-error 'cl--generic-cyclic-definition "Cyclic definition: %S")
+(define-error 'cl--generic-cyclic-definition "Cyclic definition")
 
 (defun cl--generic-build-combined-method (generic methods)
   (if (null methods)
diff --git a/lisp/emacs-lisp/gv.el b/lisp/emacs-lisp/gv.el
index d6272a5..ebcc63c 100644
--- a/lisp/emacs-lisp/gv.el
+++ b/lisp/emacs-lisp/gv.el
@@ -74,7 +74,7 @@
 ;; (defvar gv--macro-environment nil
 ;;   "Macro expanders for generalized variables.")
 
-(define-error 'gv-invalid-place "%S is not a valid place expression")
+(define-error 'gv-invalid-place "Invalid place expression")
 
 ;;;###autoload
 (defun gv-get (place do)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]