emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

master a8c3e8e2a6: Fix child frame unlinking on Haiku


From: Po Lu
Subject: master a8c3e8e2a6: Fix child frame unlinking on Haiku
Date: Fri, 31 Dec 2021 06:05:31 -0500 (EST)

branch: master
commit a8c3e8e2a6efa77b38110a9c1fee1ece8d8da4d5
Author: Po Lu <luangruo@yahoo.com>
Commit: Po Lu <luangruo@yahoo.com>

    Fix child frame unlinking on Haiku
    
    * src/haiku_support.cc (UnlinkChild): Fix obvious mistake.
    (DoMove): Lock child frame window before moving it.
---
 src/haiku_support.cc | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/haiku_support.cc b/src/haiku_support.cc
index 66b0e519b0..fea0684b1b 100644
--- a/src/haiku_support.cc
+++ b/src/haiku_support.cc
@@ -346,8 +346,8 @@ public:
          {
            if (last)
              last->next = tem->next;
-           if (tem == subset_windows)
-             subset_windows = NULL;
+           else
+             subset_windows = tem->next;
            delete tem;
            return;
          }
@@ -405,9 +405,11 @@ public:
   DoMove (struct child_frame *f)
   {
     BRect frame = this->Frame ();
+    if (!f->window->LockLooper ())
+      gui_abort ("Failed to lock child frame window for move");
     f->window->MoveTo (frame.left + f->xoff,
                       frame.top + f->yoff);
-    this->Sync ();
+    f->window->UnlockLooper ();
   }
 
   void



reply via email to

[Prev in Thread] Current Thread [Next in Thread]