emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-29 9f5008b9b2: Improve error message from sqlite-mode.el


From: Eli Zaretskii
Subject: emacs-29 9f5008b9b2: Improve error message from sqlite-mode.el
Date: Sun, 15 Jan 2023 05:07:49 -0500 (EST)

branch: emacs-29
commit 9f5008b9b2af4f96cecff5f878657dc8cad4de80
Author: Eli Zaretskii <eliz@gnu.org>
Commit: Eli Zaretskii <eliz@gnu.org>

    Improve error message from sqlite-mode.el
    
    * lisp/sqlite-mode.el (sqlite-mode-open-file): Add error
    checking.  (Bug#60490)
---
 lisp/sqlite-mode.el | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lisp/sqlite-mode.el b/lisp/sqlite-mode.el
index 83762b6194..c3047c786f 100644
--- a/lisp/sqlite-mode.el
+++ b/lisp/sqlite-mode.el
@@ -55,10 +55,14 @@
   (interactive "fSQLite file name: ")
   (unless (sqlite-available-p)
     (error "This Emacs doesn't have SQLite support, so it can't view SQLite 
files"))
+  (if (file-remote-p file)
+      (error "Remote SQLite files are not yet supported"))
   (pop-to-buffer (get-buffer-create
                   (format "*SQLite %s*" (file-name-nondirectory file))))
   (sqlite-mode)
   (setq-local sqlite--db (sqlite-open file))
+  (unless (sqlitep sqlite--db)
+    (error "`sqlite-open' failed to open SQLite file"))
   (sqlite-mode-list-tables))
 
 (defun sqlite-mode-list-tables ()



reply via email to

[Prev in Thread] Current Thread [Next in Thread]