emacs-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

emacs-30 969498c25d0: Remove dangerous HTML edit from admin.el


From: Eli Zaretskii
Subject: emacs-30 969498c25d0: Remove dangerous HTML edit from admin.el
Date: Sun, 25 Aug 2024 08:46:42 -0400 (EDT)

branch: emacs-30
commit 969498c25d0112dbdc3aa2ef75dc63681101203e
Author: Eli Zaretskii <eliz@gnu.org>
Commit: Eli Zaretskii <eliz@gnu.org>

    Remove dangerous HTML edit from admin.el
    
    * admin/admin.el (manual-html-fix-index-2): Avoid lax matches with
    "<ul>" which could mistakenly edit unrelated parts of HTML.
    (Bug#72761)
---
 admin/admin.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/admin/admin.el b/admin/admin.el
index a4d3720ab69..edd3246a1a3 100644
--- a/admin/admin.el
+++ b/admin/admin.el
@@ -613,9 +613,7 @@ style=\"text-align:left\">")
       ;; item is not there anymore.  So for HTML manuals produced by
       ;; those newer versions of Texinfo we punt and leave the menu in
       ;; its original form.
-      (when (or (search-forward "<ul class=\"menu\">" nil t)
-               ;; FIXME?  The following search seems dangerously lax.
-               (search-forward "<ul>" nil t))
+      (when (or (search-forward "<ul class=\"menu\">" nil t))
         ;; Convert the list that Makeinfo made into a table.
         (replace-match "<table style=\"float:left\" width=\"100%\">")
         (forward-line 1)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]