emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[elpa] 09/14: company-gtags-modes: Turn into defcustom


From: Dmitry Gutov
Subject: [elpa] 09/14: company-gtags-modes: Turn into defcustom
Date: Sat, 13 Sep 2014 12:19:02 +0000

dgutov pushed a commit to branch master
in repository elpa.

commit 820050bfd7e56a7202008a2a27f3d9e7001c95da
Author: Dmitry Gutov <address@hidden>
Date:   Tue Sep 9 05:08:03 2014 +0400

    company-gtags-modes: Turn into defcustom
    
    Closes #178.
---
 NEWS.md          |    1 +
 company-gtags.el |    9 +++++++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index 50096a3..a11b4d9 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -2,6 +2,7 @@
 
 ## Next
 
+* `company-gtags` is enabled in all `prog-mode` derivatives by default.
 * `company-end-of-buffer-workaround` is not used anymore.
 * `company-begin-commands` includes several `cc-mode` commands.
 
diff --git a/company-gtags.el b/company-gtags.el
index d2f1e78..70c5ad5 100644
--- a/company-gtags.el
+++ b/company-gtags.el
@@ -48,7 +48,12 @@
 
 (defvar-local company-gtags--tags-available-p 'unknown)
 
-(defvar company-gtags-modes '(c-mode c++-mode jde-mode java-mode php-mode))
+(defcustom company-gtags-modes '(prog-mode jde-mode)
+  "Modes that use `company-gtags'.
+In all these modes (and their derivatives) `company-gtags' will perform
+completion."
+  :type '(repeat (symbol :tag "Major mode"))
+  :package-version '(company . "0.8.4"))
 
 (defun company-gtags--tags-available-p ()
   (if (eq company-gtags--tags-available-p 'unknown)
@@ -90,7 +95,7 @@
   (cl-case command
     (interactive (company-begin-backend 'company-gtags))
     (prefix (and company-gtags-executable
-                 (memq major-mode company-gtags-modes)
+                 (apply #'derived-mode-p company-gtags-modes)
                  (not (company-in-string-or-comment))
                  (company-gtags--tags-available-p)
                  (or (company-grab-symbol) 'stop)))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]