[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[elpa] master d6e6cd6 06/33: Fix object keys highlighting (closes #234)
From: |
Dmitry Gutov |
Subject: |
[elpa] master d6e6cd6 06/33: Fix object keys highlighting (closes #234) |
Date: |
Sun, 12 Jul 2015 22:35:35 +0000 |
branch: master
commit d6e6cd6a5249d86248e825425b73066f0fc3286e
Author: Dmitry Gutov <address@hidden>
Commit: Dmitry Gutov <address@hidden>
Fix object keys highlighting (closes #234)
Regression from c13eda4.
---
js2-mode.el | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/js2-mode.el b/js2-mode.el
index 082a5d0..d775d65 100644
--- a/js2-mode.el
+++ b/js2-mode.el
@@ -10439,7 +10439,6 @@ When `js2-is-in-destructuring' is t, forms like {a, b,
c} will be permitted."
(js2-create-name-node))
;; Anything else is an error
(t (js2-report-error "msg.bad.prop"))))
- expr
(prop (and previous-token (js2-token-string previous-token)))
(property-type (when previous-token
(if (= (js2-token-type previous-token) js2-MUL)
@@ -10459,19 +10458,21 @@ When `js2-is-in-destructuring' is t, forms like {a,
b, c} will be permitted."
(js2-parse-getter-setter-prop pos key property-type))
;; regular prop
(t
- (prog1
- (setq expr (js2-parse-plain-property key))
+ (let ((beg (js2-current-token-beg))
+ (end (js2-current-token-end))
+ (expr (js2-parse-plain-property key)))
(when (and (= tt js2-NAME)
(not js2-is-in-destructuring)
js2-highlight-external-variables
(js2-node-get-prop expr 'SHORTHAND))
(js2-record-name-node key))
- (js2-set-face (js2-current-token-beg) (js2-current-token-end)
+ (js2-set-face beg end
(if (js2-function-node-p
(js2-object-prop-node-right expr))
'font-lock-function-name-face
'font-lock-variable-name-face)
- 'record))))))
+ 'record)
+ expr)))))
(defun js2-parse-plain-property (prop)
"Parse a non-getter/setter property in an object literal.
- [elpa] master updated (af721ab -> 2763c9a), Dmitry Gutov, 2015/07/12
- [elpa] master 6d4aa28 03/33: Don't unset `js2-recorded-identifiers', Dmitry Gutov, 2015/07/12
- [elpa] master 709ff60 05/33: Add a NEWS entry for d4d9c54, Dmitry Gutov, 2015/07/12
- [elpa] master a632b02 04/33: Merge pull request #232 from jacksonrayhamilton/unset-identifiers, Dmitry Gutov, 2015/07/12
- [elpa] master d6e6cd6 06/33: Fix object keys highlighting (closes #234),
Dmitry Gutov <=
- [elpa] master 422be2d 08/33: Add NEWS entry, Dmitry Gutov, 2015/07/12
- [elpa] master c13eda4 01/33: Generalize object literal parsing to support short-hand function/generator/getter/setter declarations with all kinds of keys (string, named, computed, numeric)., Dmitry Gutov, 2015/07/12
- [elpa] master 09a86b2 09/33: js2-node-externs: Add querystring, Dmitry Gutov, 2015/07/12
- [elpa] master 7c423dd 10/33: Define const variables in the current block., Dmitry Gutov, 2015/07/12
- [elpa] master d39764f 02/33: Merge pull request #231 from shicks/computed, Dmitry Gutov, 2015/07/12
- [elpa] master 88d7565 11/33: Respect strict mode., Dmitry Gutov, 2015/07/12
- [elpa] master a5b586f 13/33: Test const scoping., Dmitry Gutov, 2015/07/12
- [elpa] master 254c78c 07/33: Highlight unused and/or uninitialized variables, Dmitry Gutov, 2015/07/12
- [elpa] master 1277c7d 12/33: Track script and function strict mode., Dmitry Gutov, 2015/07/12
- [elpa] master 498bcca 21/33: Fix refactoring regression., Dmitry Gutov, 2015/07/12